From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7DABFC19; Thu, 25 Jul 2024 14:49:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721918948; cv=none; b=ZU68K3l+vuxBzvprrZH3x2jhZttnGSp2CcitddH1GyUKyXQ2whJilWn2LXo8i5DwxlIjdOGCfeDxR6Pe5kh+0qSoq9C1tOHSVQbPJgZanxnQA5dx1kDSfxnUGBxhPSMIWaun45KZ3Ywqt6A0uwIyehB1lGRNEuXbQ4aZqjS3k98= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721918948; c=relaxed/simple; bh=9dYGtlSuBgmuyWCTlu020P9nN7ED8oVFTkLMPypANfA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VVsYAlnOjz9+L83MSxmiXIQHuXuvasBPVrYRW+cmCMhppRmbodHBrSDerFxX6JC+pS4qM3A3G5ntp/rq6oR0SgQBYL2JS8Bkk0ioINryfX5CAj51Ad/F6HNIKEI2ojG+P5BMKbWRe8oplcrtrKLnV3LFcv50FM6E21r3F9iU7wg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=sPXzCONu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="sPXzCONu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F607C116B1; Thu, 25 Jul 2024 14:49:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1721918948; bh=9dYGtlSuBgmuyWCTlu020P9nN7ED8oVFTkLMPypANfA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sPXzCONulbPiSvlm7TB+BLkgNnPLtXDmgU6ShvV3neDyzCF2cyQPyUj53qgwbe6PI M5TG3Qw1SPDg+ax5vmw9cwMeQxxXNg2yYA6WjkiBLDwldt8fPd2sNLqScrrnOjHHsj 2AH5B3vpCLuYwwR+7aFWdcwkelKD32vh25F43rtU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot , Tetsuo Handa , Luiz Augusto von Dentz , Sasha Levin Subject: [PATCH 5.10 38/59] Bluetooth: hci_core: cancel all works upon hci_unregister_dev() Date: Thu, 25 Jul 2024 16:37:28 +0200 Message-ID: <20240725142734.700605239@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240725142733.262322603@linuxfoundation.org> References: <20240725142733.262322603@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tetsuo Handa [ Upstream commit 0d151a103775dd9645c78c97f77d6e2a5298d913 ] syzbot is reporting that calling hci_release_dev() from hci_error_reset() due to hci_dev_put() from hci_error_reset() can cause deadlock at destroy_workqueue(), for hci_error_reset() is called from hdev->req_workqueue which destroy_workqueue() needs to flush. We need to make sure that hdev->{rx_work,cmd_work,tx_work} which are queued into hdev->workqueue and hdev->{power_on,error_reset} which are queued into hdev->req_workqueue are no longer running by the moment destroy_workqueue(hdev->workqueue); destroy_workqueue(hdev->req_workqueue); are called from hci_release_dev(). Call cancel_work_sync() on these work items from hci_unregister_dev() as soon as hdev->list is removed from hci_dev_list. Reported-by: syzbot Closes: https://syzkaller.appspot.com/bug?extid=da0a9c9721e36db712e8 Signed-off-by: Tetsuo Handa Signed-off-by: Luiz Augusto von Dentz Signed-off-by: Sasha Levin --- net/bluetooth/hci_core.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c index b9cf5bc9364c1..c8c1cd55c0eb0 100644 --- a/net/bluetooth/hci_core.c +++ b/net/bluetooth/hci_core.c @@ -3839,7 +3839,11 @@ void hci_unregister_dev(struct hci_dev *hdev) list_del(&hdev->list); write_unlock(&hci_dev_list_lock); + cancel_work_sync(&hdev->rx_work); + cancel_work_sync(&hdev->cmd_work); + cancel_work_sync(&hdev->tx_work); cancel_work_sync(&hdev->power_on); + cancel_work_sync(&hdev->error_reset); if (!test_bit(HCI_QUIRK_NO_SUSPEND_NOTIFIER, &hdev->quirks)) { hci_suspend_clear_tasks(hdev); -- 2.43.0