From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81E0B1C233B; Tue, 30 Jul 2024 16:00:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722355235; cv=none; b=hlHvwz207Fb8u0nY1L69UL+CTituer128z+2npkPVMnhkII+yGxNMuM0dim6on8Dj0vU0TAYbruPh+1UkBbQsFtF1Ro/ipDkzCTxGuBIokjhvstlU4NiAGNONhDW1CYyyXxDbzt22ysIzeNRJ8zAlAhwyopP5iIMkpzGZH0ZqwA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722355235; c=relaxed/simple; bh=+rj99h8neC34Mpalh6QK7jZA18couID+aNCwWdGYiec=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qFvwhXNrbQhgRYrQ5uNi9hui299wqCCNhhF5IQanyfCTaZK7qL4gX0xhEGJ25j59sgLw35Cu0B5Nj+9mtbU7nSQrWLkhfeTGLnWywBi32kLAcIVDEodZPkjodA3QBYOvRqR5HmpL8hQmXZ75443Pv3bkcKSgkxnpvZwB/TrDVw8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=0ZnZGtX+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="0ZnZGtX+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0400C32782; Tue, 30 Jul 2024 16:00:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1722355235; bh=+rj99h8neC34Mpalh6QK7jZA18couID+aNCwWdGYiec=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0ZnZGtX+imHb4DWhzivzqdSd5EQoKfaGTOgNhqg+h3ngPnh5I0sJbR6UKaAkxkAkH ki8OWBZGvAxDHnO43n0XNsUH1QCALyxwH8yG1pmY6no7SG3jeUnhPB54GeeeAyStI6 XaGh9hBlQtlrMgIaOgDx94U3NYMAjzuMlgV8SeH4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Primoz Fiser , Viresh Kumar , Sasha Levin Subject: [PATCH 6.1 046/440] OPP: ti: Fix ti_opp_supply_probe wrong return values Date: Tue, 30 Jul 2024 17:44:39 +0200 Message-ID: <20240730151617.562469218@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240730151615.753688326@linuxfoundation.org> References: <20240730151615.753688326@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Primoz Fiser [ Upstream commit 3a1ac6b8f603a9310274990a0ad563a5fb709f59 ] Function ti_opp_supply_probe() since commit 6baee034cb55 ("OPP: ti: Migrate to dev_pm_opp_set_config_regulators()") returns wrong values when all goes well and hence driver probing eventually fails. Fixes: 6baee034cb55 ("OPP: ti: Migrate to dev_pm_opp_set_config_regulators()") Signed-off-by: Primoz Fiser Signed-off-by: Viresh Kumar Signed-off-by: Sasha Levin --- drivers/opp/ti-opp-supply.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/opp/ti-opp-supply.c b/drivers/opp/ti-opp-supply.c index 8f3f13fbbb25a..a8a696d2e03ab 100644 --- a/drivers/opp/ti-opp-supply.c +++ b/drivers/opp/ti-opp-supply.c @@ -400,10 +400,12 @@ static int ti_opp_supply_probe(struct platform_device *pdev) } ret = dev_pm_opp_set_config_regulators(cpu_dev, ti_opp_config_regulators); - if (ret < 0) + if (ret < 0) { _free_optimized_voltages(dev, &opp_data); + return ret; + } - return ret; + return 0; } static struct platform_driver ti_opp_supply_driver = { -- 2.43.0