From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A9061A6192; Tue, 30 Jul 2024 16:39:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722357578; cv=none; b=q7PpPYgJR8Rku8U6+FRnWXvQnPw4Oi7y1xngIdS2VILgKMatDMPyjrvOdNc2noK+9GLvWWwElP30BUKEtviPIzcXZuqKRgGeiikIHrLKYPMRd0BSIGeDokEu8yd1rZM3DCSKmGYHYU9Zy72iINZXDXnx8QimRNpSMy4qYUifvgo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722357578; c=relaxed/simple; bh=GU1avLtTMZxGIxluB4oKBziVkv4iZmXQfRFc5uqHaJM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hgJRjDGDcIlQ5YIP+Nc3lsptR4LgPNYiySW6eXcUZIGE2XlP1t7wl58vyBpsAKs34yL70TQQPgFs1ZqmO8adWf5NV2ZKNcoPVAHRbUr6N2N6OVGfkB0ziXDbZuhQFrkEdJCL9lStWPTBQ02G4tdQHq++6BG6UWkiphhbbMXwwtY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1zJkAKKQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1zJkAKKQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C029C32782; Tue, 30 Jul 2024 16:39:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1722357578; bh=GU1avLtTMZxGIxluB4oKBziVkv4iZmXQfRFc5uqHaJM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1zJkAKKQwYPNoRJoczFZOtmWeLHgURibUcPqEwdzctsM934wUDDcV14Ml7A2ZJAGu 3sDpv8ZnZAuMTzjyKLuKrQ/yhY0qICnumxiQLTgIqbfLVXBOInB+CksLE8evL+ybsX Brq9IJFNZrakyHCmh9z+WCRTv2ZCW/ZK0wzmzIc8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Andrei Lalaev , Marco Felsch , Dmitry Torokhov , Sasha Levin Subject: [PATCH 6.6 271/568] Input: qt1050 - handle CHIP_ID reading error Date: Tue, 30 Jul 2024 17:46:18 +0200 Message-ID: <20240730151650.474057096@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240730151639.792277039@linuxfoundation.org> References: <20240730151639.792277039@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Andrei Lalaev [ Upstream commit 866a5c7e2781cf1b019072288f1f5c64186dcb63 ] If the device is missing, we get the following error: qt1050 3-0041: ID -1340767592 not supported Let's handle this situation and print more informative error when reading of CHIP_ID fails: qt1050 3-0041: Failed to read chip ID: -6 Fixes: cbebf5addec1 ("Input: qt1050 - add Microchip AT42QT1050 support") Signed-off-by: Andrei Lalaev Reviewed-by: Marco Felsch Link: https://lore.kernel.org/r/20240617183018.916234-1-andrey.lalaev@gmail.com Signed-off-by: Dmitry Torokhov Signed-off-by: Sasha Levin --- drivers/input/keyboard/qt1050.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/input/keyboard/qt1050.c b/drivers/input/keyboard/qt1050.c index 6953097db4456..cd2f4216daf86 100644 --- a/drivers/input/keyboard/qt1050.c +++ b/drivers/input/keyboard/qt1050.c @@ -226,7 +226,12 @@ static bool qt1050_identify(struct qt1050_priv *ts) int err; /* Read Chip ID */ - regmap_read(ts->regmap, QT1050_CHIP_ID, &val); + err = regmap_read(ts->regmap, QT1050_CHIP_ID, &val); + if (err) { + dev_err(&ts->client->dev, "Failed to read chip ID: %d\n", err); + return false; + } + if (val != QT1050_CHIP_ID_VER) { dev_err(&ts->client->dev, "ID %d not supported\n", val); return false; -- 2.43.0