From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 542951B583E; Tue, 30 Jul 2024 15:58:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722355096; cv=none; b=A6zG3X+HemorhaUf33htZZB4sywDSV26776XcLxsZ8F3mzV/X4u8/xOTY7YGvoXKe+RtR5F4gukXy799/dduvzUg92IBMWduGlCV8w3iuiUnh1aAHG9QCYQW11ZX/kIO7vgO0Xqku+UtutFUm9RLcL/CanEe2YLXWA3OOSpgS9U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722355096; c=relaxed/simple; bh=RTCvWoswbUTb95cxWSp+ZdNqT66n+NrhhgPMbauNR04=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XHaGUZM8BaV2fHv7UP+7/iSY6qwiom06+BlJipBoWPxhBvuOgpDv7hb0oZvyQnRGPGXQx+wBoeL9iZU8MiiYzLt16gjHqF/ic5IJWnveDXp6U5DPp/t2Y5HYXYT1EWq6U3LqirRmLshZCp4Hoeh8m1nWa+0vWQf1lOwjNhasW6c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=qAaRkhSb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="qAaRkhSb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B71F6C4AF0A; Tue, 30 Jul 2024 15:58:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1722355096; bh=RTCvWoswbUTb95cxWSp+ZdNqT66n+NrhhgPMbauNR04=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qAaRkhSbnxKL6WSTrz1IuWnEBM94jLK+TUqs5fsyXRfrVQyGxGWkj/zZBdDYHXQI5 +VMhyq0nXpooqxZ2ifgrxkohTMYfaDAtf7eFy/jhg9Mk4AnJvvmDnHsr8/Z1WEN323 5LUMlW99oo+NvKaHdTC69fOMjqp/va5EK+LFxxz8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , "Borislav Petkov (AMD)" , Andy Shevchenko , Sasha Levin Subject: [PATCH 6.10 019/809] x86/pci/intel_mid_pci: Fix PCIBIOS_* return code handling Date: Tue, 30 Jul 2024 17:38:15 +0200 Message-ID: <20240730151725.419086452@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240730151724.637682316@linuxfoundation.org> References: <20240730151724.637682316@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ilpo Järvinen [ Upstream commit 724852059e97c48557151b3aa4af424614819752 ] intel_mid_pci_irq_enable() uses pci_read_config_byte() that returns PCIBIOS_* codes. The error handling, however, assumes the codes are normal errnos because it checks for < 0. intel_mid_pci_irq_enable() also returns the PCIBIOS_* code back to the caller but the function is used as the (*pcibios_enable_irq) function which should return normal errnos. Convert the error check to plain non-zero check which works for PCIBIOS_* return codes and convert the PCIBIOS_* return code using pcibios_err_to_errno() into normal errno before returning it. Fixes: 5b395e2be6c4 ("x86/platform/intel-mid: Make IRQ allocation a bit more flexible") Signed-off-by: Ilpo Järvinen Signed-off-by: Borislav Petkov (AMD) Reviewed-by: Andy Shevchenko Link: https://lore.kernel.org/r/20240527125538.13620-2-ilpo.jarvinen@linux.intel.com Signed-off-by: Sasha Levin --- arch/x86/pci/intel_mid_pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/pci/intel_mid_pci.c b/arch/x86/pci/intel_mid_pci.c index 8edd622066044..722a33be08a18 100644 --- a/arch/x86/pci/intel_mid_pci.c +++ b/arch/x86/pci/intel_mid_pci.c @@ -233,9 +233,9 @@ static int intel_mid_pci_irq_enable(struct pci_dev *dev) return 0; ret = pci_read_config_byte(dev, PCI_INTERRUPT_LINE, &gsi); - if (ret < 0) { + if (ret) { dev_warn(&dev->dev, "Failed to read interrupt line: %d\n", ret); - return ret; + return pcibios_err_to_errno(ret); } id = x86_match_cpu(intel_mid_cpu_ids); -- 2.43.0