From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8004187FF2; Tue, 30 Jul 2024 16:03:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722355435; cv=none; b=CKzfB+HbbZqHy9fsfs8IhXXh/axrwDbCYmJr695PcBMWa1nDKIT8vOyX7qqvA83wptzLKeuqek0QJSO5u7tyxYBn7wFiNxEsjFvDXByxR1UiIE3L/nG3DZuMnYUggnb3fbSmg97h7FVSl4baW0/JvWlolJ28D7nhrzvh486ExHg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722355435; c=relaxed/simple; bh=Q/Gw6D1y3oNxY5jCmaac1LfqJGTryASSxOyT82kj6/c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=c3A4huXWYbmwJ+7IkKXB2QC6zKBFxHkhEAaF1362wqqrB1KcEQv0IXgbubmXAgf7J2spWwMrrREJTfFegHv1xuojyGWHcsn8+uW6Hk7bjH4AovAuJPNUwwdwoVNeiAnUjnl1GtUCugT+GWdCVn4OC8/cBFBXJAhy7yON3knda+E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Dsv3lJcv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Dsv3lJcv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 00A2FC32782; Tue, 30 Jul 2024 16:03:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1722355435; bh=Q/Gw6D1y3oNxY5jCmaac1LfqJGTryASSxOyT82kj6/c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Dsv3lJcvGF0xzHDRW2ODqWZlO+Ny9F2fqzsKRGhdqVCjdLMa/kQ9HmW5BpiHauINV r28YVacFMir7Wxg6T9FCY1pf/7zAQ8EJlvOAyKoAEAkqmTtBDIqdCnlg1+WL9B7WjT vYlnD8a5jzbHTudYfAAGuZhJBZnmRXoL+TfJnlCg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Sasha Levin Subject: [PATCH 6.10 032/809] pwm: stm32: Always do lazy disabling Date: Tue, 30 Jul 2024 17:38:28 +0200 Message-ID: <20240730151725.922374173@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240730151724.637682316@linuxfoundation.org> References: <20240730151724.637682316@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Uwe Kleine-König [ Upstream commit 7346e7a058a2c9aa9ff1cc699c7bf18a402d9f84 ] When the state changes from enabled to disabled, polarity, duty_cycle and period are not configured in hardware and TIM_CCER_CCxE is just cleared. However if the state changes from one disabled state to another, all parameters are written to hardware because the early exit from stm32_pwm_apply() is only taken if the pwm is currently enabled. This yields surprises like: Applying { .period = 1, .duty_cycle = 0, .enabled = false } succeeds if the pwm is initially on, but fails if it's already off because 1 is a too small period. Update the check for lazy disable to always exit early if the target state is disabled, no matter what is currently configured. Fixes: 7edf7369205b ("pwm: Add driver for STM32 plaftorm") Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20240703110010.672654-2-u.kleine-koenig@baylibre.com Signed-off-by: Uwe Kleine-König Signed-off-by: Sasha Levin --- drivers/pwm/pwm-stm32.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/pwm/pwm-stm32.c b/drivers/pwm/pwm-stm32.c index 8bae3fd2b3306..c586029caf233 100644 --- a/drivers/pwm/pwm-stm32.c +++ b/drivers/pwm/pwm-stm32.c @@ -452,8 +452,9 @@ static int stm32_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, enabled = pwm->state.enabled; - if (enabled && !state->enabled) { - stm32_pwm_disable(priv, pwm->hwpwm); + if (!state->enabled) { + if (enabled) + stm32_pwm_disable(priv, pwm->hwpwm); return 0; } -- 2.43.0