From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED9F81A6166; Tue, 30 Jul 2024 16:45:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722357956; cv=none; b=H1YGsd2+xXoovLtUd4J9D+u7snPOEOk+W4Kw4NJUzpIYtUGslImtM9iY/GnwB+6BAOygsd19zbTZ8I7KA4JUnD44pEPXRwxJP49i51DsGGiE2dDWNMavI42bapDTgCJxOIpyMhozxCrktWiO0tNWvzbwHixBdZL0l0d+WAoy/C8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722357956; c=relaxed/simple; bh=Loqe/KBr9MGYDziaiaBXM0kXXADvLeVKvMcfQP0hC5E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QX4XlOFldS7qjmnNSe0/lxjnMELd0SvQ0Km/0Swiq9HMypcBhlo9Ajgkk2sDY0Ye2UlLtSYj1TbINaDkExM6anwIwkyxC2uVykm+C9g/lrO9yY+M1Z9P2TjidUSHQus9fii56T4K3CCY2poNhE2aTQnWFIHXcJGb4Y5HS9xopTQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=LSPDVLLY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="LSPDVLLY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73C46C4AF0A; Tue, 30 Jul 2024 16:45:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1722357955; bh=Loqe/KBr9MGYDziaiaBXM0kXXADvLeVKvMcfQP0hC5E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LSPDVLLYo1dZppPEdHA+OTekqzYwcTC+C6tAX3P2UdMRCFgxXpkif0CAZTYNDTSO5 Lu/BviNsjmr7IvNoG0/fqNxIdU3LgLoq+VV64srhO2m1pZ8Tous4Uhu60HWWB3XqLR VcBoXMz7bbLQA4Egh9KNuEgvxbKsNoT4WXwhKnOo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Aleksandr Burakov , Hans Verkuil , Sasha Levin Subject: [PATCH 6.10 309/809] saa7134: Unchecked i2c_transfer function result fixed Date: Tue, 30 Jul 2024 17:43:05 +0200 Message-ID: <20240730151736.803846453@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240730151724.637682316@linuxfoundation.org> References: <20240730151724.637682316@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Aleksandr Burakov [ Upstream commit 9d8683b3fd93f0e378f24dc3d9604e5d7d3e0a17 ] Return value of function 'i2c_transfer' is not checked that may cause undefined behaviour. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 2cf36ac44730 ("[PATCH] v4l: 656: added support for the following cards") Signed-off-by: Aleksandr Burakov Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/pci/saa7134/saa7134-dvb.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/saa7134/saa7134-dvb.c b/drivers/media/pci/saa7134/saa7134-dvb.c index 9c6cfef03331d..a66df6adfaad8 100644 --- a/drivers/media/pci/saa7134/saa7134-dvb.c +++ b/drivers/media/pci/saa7134/saa7134-dvb.c @@ -466,7 +466,9 @@ static int philips_europa_tuner_sleep(struct dvb_frontend *fe) /* switch the board to analog mode */ if (fe->ops.i2c_gate_ctrl) fe->ops.i2c_gate_ctrl(fe, 1); - i2c_transfer(&dev->i2c_adap, &analog_msg, 1); + if (i2c_transfer(&dev->i2c_adap, &analog_msg, 1) != 1) + return -EIO; + return 0; } @@ -1018,7 +1020,9 @@ static int md8800_set_voltage2(struct dvb_frontend *fe, else wbuf[1] = rbuf & 0xef; msg[0].len = 2; - i2c_transfer(&dev->i2c_adap, msg, 1); + if (i2c_transfer(&dev->i2c_adap, msg, 1) != 1) + return -EIO; + return 0; } -- 2.43.0