From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80DAF14AD0A; Thu, 15 Aug 2024 14:31:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723732277; cv=none; b=GWoC04AvbesaZ0nRO1gaVDDlwHkVYDrDPaDXAckRkHHLb7SoDd7fDgZgKYA7hfjQh2E90xDngU5l19bsamRLR0i1VoQCsCfVXAf2pmfci9k2fhm4JrCwgLf9NLdRaSqBb8LKzOUa2EVhMdWtQFV6MSKdE467xI47WviF6N6cHEA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723732277; c=relaxed/simple; bh=+QOiAUjNmffHVZG8O0QE42q3QlgprsKOwQSffyOODOw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kux5cGZm+fl+XFQHnVh0QK0T3qinfJo4GWE74f2djzxXYTuXlckzdqvPegpEYl2vXDk8wA3wt25WoahOi2LC9CLgBec7EwT7MVLyNtbs1owLYvRq1KVRVc/IiIw54c1/UrFF9F9iyC10GduR2eElz7lkTM6n8KETImGL+X2UH5Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=B0lHcrZX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="B0lHcrZX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0633AC4AF0D; Thu, 15 Aug 2024 14:31:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1723732277; bh=+QOiAUjNmffHVZG8O0QE42q3QlgprsKOwQSffyOODOw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=B0lHcrZXEhtA80LmX5sawb+O1lg1hemjuX0r+MU7RT2DX1IXsX/hSiVPyAnyy47Ho XMesbD8d6l8ZOzVkrj79VDaGcMhCQI4vK03lYMuJgGPOMp2UF0Ul0Xu7sdASyeQMgC m0ETqgYhnQUuj9xteAWcRTs04CS/4UU2r+AEgylw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Joe Hattori , Jarkko Sakkinen Subject: [PATCH 5.10 130/352] char: tpm: Fix possible memory leak in tpm_bios_measurements_open() Date: Thu, 15 Aug 2024 15:23:16 +0200 Message-ID: <20240815131924.279330319@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240815131919.196120297@linuxfoundation.org> References: <20240815131919.196120297@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Joe Hattori commit 5d8e2971e817bb64225fc0b6327a78752f58a9aa upstream. In tpm_bios_measurements_open(), get_device() is called on the device embedded in struct tpm_chip. In the error path, however, put_device() is not called. This results in a reference count leak, which prevents the device from being properly released. This commit makes sure to call put_device() when the seq_open() call fails. Cc: stable@vger.kernel.org # +v4.18 Fixes: 9b01b5356629 ("tpm: Move shared eventlog functions to common.c") Signed-off-by: Joe Hattori Signed-off-by: Jarkko Sakkinen Signed-off-by: Greg Kroah-Hartman --- drivers/char/tpm/eventlog/common.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/char/tpm/eventlog/common.c +++ b/drivers/char/tpm/eventlog/common.c @@ -47,6 +47,8 @@ static int tpm_bios_measurements_open(st if (!err) { seq = file->private_data; seq->private = chip; + } else { + put_device(&chip->dev); } return err;