From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 505C72772A; Thu, 15 Aug 2024 14:32:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723732379; cv=none; b=BpQrrI/FMnsm93rCi2etUZW9ZRvWelzCsOWSFBpKo13qmpfGDnH67+0l9M9GWlMgg1/G8hNlMufC7v2AzHo+sPoi4KBhklQ1ty94YY7bmKY83BpUbLIMxgFqcNCvp2vTmTNfjTTatZmpl7atjO3kDch29zER5z8mdMyhCLtDE0E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723732379; c=relaxed/simple; bh=HkPYrUVtCEzsEOwtXSbFA6JFI3PkiR3YpqiurIDKhkM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=krJuy2Z/ygKHIE2R7szqRIfP/1zkZLABrGoPSVyOLAcsDEffU6ampyYCtUzRjzGYbnTJDjp5eEq1uKGZj3mg4rIgZhojj5ajY78/YDypuJZPVY5Dmlh9IwbM0mvsK59LOJIO1QmFk+upgRd6CqxDrJS+uJ5f+tPfgTOiPc7LaYg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=td05HDm0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="td05HDm0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C67C2C32786; Thu, 15 Aug 2024 14:32:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1723732379; bh=HkPYrUVtCEzsEOwtXSbFA6JFI3PkiR3YpqiurIDKhkM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=td05HDm0EkpAiTnnQAkY478mx+kL29QKQ+phnokbQHqpK8xKh+a7ml8VyyruxNG0M J7FM/manl9a3CTxA5IwiqzWwRei3BA3xbVTSSkapsIQU/ptoyfg1CNyU76yY0hWCe3 5o/8B5E8sp8UhLiSfu9EtKwEFBkDQL1SFEs8wne4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Zijun Hu , Lk Sii Subject: [PATCH 5.10 162/352] kobject_uevent: Fix OOB access within zap_modalias_env() Date: Thu, 15 Aug 2024 15:23:48 +0200 Message-ID: <20240815131925.532798227@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240815131919.196120297@linuxfoundation.org> References: <20240815131919.196120297@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zijun Hu commit dd6e9894b451e7c85cceb8e9dc5432679a70e7dc upstream. zap_modalias_env() wrongly calculates size of memory block to move, so will cause OOB memory access issue if variable MODALIAS is not the last one within its @env parameter, fixed by correcting size to memmove. Fixes: 9b3fa47d4a76 ("kobject: fix suppressing modalias in uevents delivered over netlink") Cc: stable@vger.kernel.org Signed-off-by: Zijun Hu Reviewed-by: Lk Sii Link: https://lore.kernel.org/r/1717074877-11352-1-git-send-email-quic_zijuhu@quicinc.com Signed-off-by: Greg Kroah-Hartman --- lib/kobject_uevent.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) --- a/lib/kobject_uevent.c +++ b/lib/kobject_uevent.c @@ -432,8 +432,23 @@ static void zap_modalias_env(struct kobj len = strlen(env->envp[i]) + 1; if (i != env->envp_idx - 1) { + /* @env->envp[] contains pointers to @env->buf[] + * with @env->buflen chars, and we are removing + * variable MODALIAS here pointed by @env->envp[i] + * with length @len as shown below: + * + * 0 @env->buf[] @env->buflen + * --------------------------------------------- + * ^ ^ ^ ^ + * | |-> @len <-| target block | + * @env->envp[0] @env->envp[i] @env->envp[i + 1] + * + * so the "target block" indicated above is moved + * backward by @len, and its right size is + * @env->buflen - (@env->envp[i + 1] - @env->envp[0]). + */ memmove(env->envp[i], env->envp[i + 1], - env->buflen - len); + env->buflen - (env->envp[i + 1] - env->envp[0])); for (j = i; j < env->envp_idx - 1; j++) env->envp[j] = env->envp[j + 1] - len;