From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB7513214; Thu, 15 Aug 2024 14:39:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723732760; cv=none; b=fVSEqrFIQMIlf9Wej6Ds9lwnSUaFlQZsNwr6Z5Lwm1Yw3FlhJWG2s3LXKqoX9nPmGM892wi55tXlr8qWkjkUxi9zNrwIbL5liVEMry7TF2W1LoMeTv9FENWIsLxluzp5hOjV6e3EmYANM7NA1DPhPj7jGhyDbd8tiZxCWYanTcM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723732760; c=relaxed/simple; bh=DqGwGgbrHyykI7dj3Mx/L6hro7H/YpkbnSU82933BeA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DVkQxKX1qsbjS6NasbOUJ0UBIJRMaBOboOxdiqFDw5cFo0nPCsF6VpwD7NTREvM1PCt/lVtOIA/h2uyrjKlPAKdVnEBJuFoQmoVXxbIpI/04/628ughCmoN0gngF6NBEB4Cizrt/Z/h2YFshV3ctHojmtP2T7GxvLaeAVXkV1f8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=TrH7QvbJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="TrH7QvbJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D6B5C4AF0C; Thu, 15 Aug 2024 14:39:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1723732759; bh=DqGwGgbrHyykI7dj3Mx/L6hro7H/YpkbnSU82933BeA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TrH7QvbJDWhv3sPT6nRdNA8a1pb95gE965Gkv2rzAYX2HHSzmbKtIJmjrSHWiGAR8 DTS4sihYWZz6jtHGBxFqK5fgn67YkWk0y7ikHLeAs17m4nUJ47G61IA//JJ8RcHVbn bUnQL5R+A3THqREK7vVjuwBiyXDeVVnUUmRB0ruI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Heiko Carstens , Peter Oberparleiter , Alexander Gordeev , Sasha Levin Subject: [PATCH 5.10 277/352] s390/sclp: Prevent release of buffer in I/O Date: Thu, 15 Aug 2024 15:25:43 +0200 Message-ID: <20240815131930.157262428@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240815131919.196120297@linuxfoundation.org> References: <20240815131919.196120297@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Peter Oberparleiter [ Upstream commit bf365071ea92b9579d5a272679b74052a5643e35 ] When a task waiting for completion of a Store Data operation is interrupted, an attempt is made to halt this operation. If this attempt fails due to a hardware or firmware problem, there is a chance that the SCLP facility might store data into buffers referenced by the original operation at a later time. Handle this situation by not releasing the referenced data buffers if the halt attempt fails. For current use cases, this might result in a leak of few pages of memory in case of a rare hardware/firmware malfunction. Reviewed-by: Heiko Carstens Signed-off-by: Peter Oberparleiter Signed-off-by: Alexander Gordeev Signed-off-by: Sasha Levin --- drivers/s390/char/sclp_sd.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/s390/char/sclp_sd.c b/drivers/s390/char/sclp_sd.c index 1e244f78f1929..64581433c3349 100644 --- a/drivers/s390/char/sclp_sd.c +++ b/drivers/s390/char/sclp_sd.c @@ -319,8 +319,14 @@ static int sclp_sd_store_data(struct sclp_sd_data *result, u8 di) &esize); if (rc) { /* Cancel running request if interrupted */ - if (rc == -ERESTARTSYS) - sclp_sd_sync(page, SD_EQ_HALT, di, 0, 0, NULL, NULL); + if (rc == -ERESTARTSYS) { + if (sclp_sd_sync(page, SD_EQ_HALT, di, 0, 0, NULL, NULL)) { + pr_warn("Could not stop Store Data request - leaking at least %zu bytes\n", + (size_t)dsize * PAGE_SIZE); + data = NULL; + asce = 0; + } + } vfree(data); goto out; } -- 2.43.0