From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CEB01C9458; Tue, 27 Aug 2024 15:28:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724772489; cv=none; b=nYQfUPEob18bBF0jjmN1EGyt700c42qndJrZJXajCdbGgVTVxEvp+en0CaAwm2NSfUDme6nW66/jjV1HUSTh3PYYhl+1CPgkxqKFhizr+8li88Z/TauolZeUdD4eukZj0RLl4VCj1RBwnXUgzYjJdlZ+CJ5+4VkrUa8AF7gJwtc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724772489; c=relaxed/simple; bh=8yTBYYWe2AFnggXhYSjjkZB9j1RYlTz/C06v2fC6AIw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PejCzxHH0kZZ0uAfOHQ5vqyDhfolQVv7sL1SoefQloNbEUJAAUA/5/EBmYWQ4Ot142vLia6IoBRP0yT/t+2SAzcZaCb221szmsxM2jw6yeZBUTze2afUWLN51B4qpNo0uVGoyCwNTJAowHYRIcLTWTmh1yoTWSre8wSjJqZw8fs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=xdv22OXC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="xdv22OXC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B899EC61047; Tue, 27 Aug 2024 15:28:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1724772489; bh=8yTBYYWe2AFnggXhYSjjkZB9j1RYlTz/C06v2fC6AIw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xdv22OXCOvhKWNr/cEgsMNPpxgfNTrkv8S3/PSp8+K4U7k9TmxiLC9V8HHl0iOJot tPYvAE7P0A0oNVO3uw2jCwzA8wkhJAX4rZt7E36MQhTV46t+7nTs8gh3YbEMtG41GW 45HmUCn6L0MOAIVPqp4tasgvhSemJp3MSPqVTXfc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Guanrui Huang , Thomas Gleixner , Zenghui Yu , Marc Zyngier , Sasha Levin Subject: [PATCH 6.1 203/321] irqchip/gic-v3-its: Remove BUG_ON in its_vpe_irq_domain_alloc Date: Tue, 27 Aug 2024 16:38:31 +0200 Message-ID: <20240827143845.961259845@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240827143838.192435816@linuxfoundation.org> References: <20240827143838.192435816@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Guanrui Huang [ Upstream commit 382d2ffe86efb1e2fa803d2cf17e5bfc34e574f3 ] This BUG_ON() is useless, because the same effect will be obtained by letting the code run its course and vm being dereferenced, triggering an exception. So just remove this check. Signed-off-by: Guanrui Huang Signed-off-by: Thomas Gleixner Reviewed-by: Zenghui Yu Acked-by: Marc Zyngier Link: https://lore.kernel.org/r/20240418061053.96803-3-guanrui.huang@linux.alibaba.com Signed-off-by: Sasha Levin --- drivers/irqchip/irq-gic-v3-its.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index 3620bdb5200f2..a7a952bbfdc28 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -4476,8 +4476,6 @@ static int its_vpe_irq_domain_alloc(struct irq_domain *domain, unsigned int virq struct page *vprop_page; int base, nr_ids, i, err = 0; - BUG_ON(!vm); - bitmap = its_lpi_alloc(roundup_pow_of_two(nr_irqs), &base, &nr_ids); if (!bitmap) return -ENOMEM; -- 2.43.0