From: Stephen Boyd <swboyd@chromium.org>
To: Konrad Dybcio <konradybcio@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Stephen Boyd <sboyd@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
patches@lists.linux.dev, linux-clk@vger.kernel.org,
Neil Armstrong <neil.armstrong@linaro.org>,
Amit Pundir <amit.pundir@linaro.org>
Subject: [PATCH v2 0/2] clk: qcom: gcc-sm8550: Fix shared clk parking breakage
Date: Tue, 27 Aug 2024 16:12:33 -0700 [thread overview]
Message-ID: <20240827231237.1014813-1-swboyd@chromium.org> (raw)
Amit Pundir reported[1] that a recent commit 01a0a6cc8cfd ("clk: qcom:
Park shared RCGs upon registration") broke USB and audio on sm8550-hdk.
These two patches fix the issue by skipping the parking bit of the
shared RCGs for all clks except for the ones that were causing trouble,
i.e. the display RCGs on sc7180.
The first patch is all that's required, while the second patch can be
applied anytime to simplify the QUP clks that don't need to be parked.
Changes from v1: https://lore.kernel.org/r/20240819233628.2074654-1-swboyd@chromium.org
* Revert most of the bad patch, except for the sc7180 display clks that still
want to park at init
* Re-order series
[1] https://lore.kernel.org/CAMi1Hd1KQBE4kKUdAn8E5FV+BiKzuv+8FoyWQrrTHPDoYTuhgA@mail.gmail.com/
Stephen Boyd (2):
clk: qcom: dispcc-sc7180: Only park display clks at init
clk: qcom: gcc-sm8550: Don't use shared clk_ops for QUPs
drivers/clk/qcom/clk-rcg.h | 1 +
drivers/clk/qcom/clk-rcg2.c | 36 ++++++++++++++++++++--
drivers/clk/qcom/dispcc-sc7180.c | 8 ++---
drivers/clk/qcom/gcc-sm8550.c | 52 ++++++++++++++++----------------
4 files changed, 64 insertions(+), 33 deletions(-)
base-commit: 8400291e289ee6b2bf9779ff1c83a291501f017b
--
https://chromeos.dev
next reply other threads:[~2024-08-27 23:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 23:12 Stephen Boyd [this message]
2024-08-27 23:12 ` [PATCH v2 1/2] clk: qcom: dispcc-sc7180: Only park display clks at init Stephen Boyd
2024-08-28 12:22 ` Neil Armstrong
2024-08-28 17:03 ` Stephen Boyd
2024-08-27 23:12 ` [PATCH v2 2/2] clk: qcom: gcc-sm8550: Don't use shared clk_ops for QUPs Stephen Boyd
2024-08-28 12:22 ` Neil Armstrong
2024-08-28 17:13 ` Stephen Boyd
2024-08-29 8:39 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240827231237.1014813-1-swboyd@chromium.org \
--to=swboyd@chromium.org \
--cc=amit.pundir@linaro.org \
--cc=andersson@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=patches@lists.linux.dev \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox