From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 578832B9C7; Sun, 1 Sep 2024 16:43:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725208989; cv=none; b=H8KUIXEh3ALiRzpi00hfoO4iRXeq98qayJl3FeQ9eQwNPMsvBhsYrGJyes3ksZnf4gwdHBQJQXhbzAlM6yI8Ob4cqWDrzDoXXKjBfdK8dH/DLD8d06+MThuWID6RFfpLshYBhPy7PEVxZbI1bqhXF1layZFiO9fAUvb/017vmpg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725208989; c=relaxed/simple; bh=D/Y3aViHReriHdhSVTjbFCLHcAgxS3jX4oAIb7kR1fU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nCSPdvgELmFEcfuoFmJge6k5ACAwXU9TZDIOeH+jzBWbUppb7gzpMQ1ljuzdNzK2CFdkkxDy3mIzdGvS3WSw9A+v9ippr5jxXEhg4Fulg4ObxlaYHoSspcU2HCj/A9fJs0oa2CE/8JH4DUCsH+64iYS3yNHFT+iplg0GRTH0IKE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=VYR8xFCc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="VYR8xFCc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D333FC4CEC3; Sun, 1 Sep 2024 16:43:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1725208989; bh=D/Y3aViHReriHdhSVTjbFCLHcAgxS3jX4oAIb7kR1fU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VYR8xFCcPSXWR1ycr0M/4xAAU1mFa9CZpy+UyD5kEOzWvyjzFiDpIKJ1bH2toq6tf 8baEfSpQo88Xo0bYby2VEvob0pQVwJhVoFO07BjVozToYkVLXt7YcJbPBmG4dhSf4L PuQvyJNUwbAfzsVMm4VbT7hTErLnjxTe0wzHusJo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Nikolay Kuratov , Simon Horman , Jacob Keller , Jakub Kicinski Subject: [PATCH 5.4 101/134] cxgb4: add forgotten u64 ivlan cast before shift Date: Sun, 1 Sep 2024 18:17:27 +0200 Message-ID: <20240901160813.891732567@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240901160809.752718937@linuxfoundation.org> References: <20240901160809.752718937@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nikolay Kuratov commit 80a1e7b83bb1834b5568a3872e64c05795d88f31 upstream. It is done everywhere in cxgb4 code, e.g. in is_filter_exact_match() There is no reason it should not be done here Found by Linux Verification Center (linuxtesting.org) with SVACE Signed-off-by: Nikolay Kuratov Cc: stable@vger.kernel.org Fixes: 12b276fbf6e0 ("cxgb4: add support to create hash filters") Reviewed-by: Simon Horman Reviewed-by: Jacob Keller Link: https://patch.msgid.link/20240819075408.92378-1-kniv@yandex-team.ru Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c @@ -969,7 +969,8 @@ static u64 hash_filter_ntuple(struct ch_ * in the Compressed Filter Tuple. */ if (tp->vlan_shift >= 0 && fs->mask.ivlan) - ntuple |= (FT_VLAN_VLD_F | fs->val.ivlan) << tp->vlan_shift; + ntuple |= (u64)(FT_VLAN_VLD_F | + fs->val.ivlan) << tp->vlan_shift; if (tp->port_shift >= 0 && fs->mask.iport) ntuple |= (u64)fs->val.iport << tp->port_shift;