From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACB2144C93; Sun, 1 Sep 2024 16:49:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725209392; cv=none; b=T7lcHIahNgq9AWJjsmF4Nn64doj9xvXPenGB9UiBzetj73pVkcreqSx/+aQdFrUgl2uy1uCta07UJDXT6lFtPBTVQmqn8UTaPvRVUsTyrhRV6du8VtMRodVbzM02mHIPzZtOrcJhYWF6AZ6Wfbm99QWNZMo/VLb8Gp5caQKjNAQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725209392; c=relaxed/simple; bh=IDpmmLK4Xqa0ToYGEJ//CadYBJ29OIsTzORe9C4OruU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RikekgVj0JmRjjUNqiWdV27dNMWHtC+5Ff0HiZsWKwF6G1LN7eshi6DKAPVKEViNCSys0XXTZeL/bqKe303akHg/RZne2bGP3BxIrOCoWOE7ksJPeY7mT1qdel8aklLp8hIrNIOBnvF6wt9NV0cKWbHU6f7DmoQOcYBYpiL/WCs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=z9E4MfV5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="z9E4MfV5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 302D8C4CEC3; Sun, 1 Sep 2024 16:49:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1725209392; bh=IDpmmLK4Xqa0ToYGEJ//CadYBJ29OIsTzORe9C4OruU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=z9E4MfV5idsEcpjHa4hmxyv1Drz75rJfpMvgVI1OEAdyQ8rWgK3e9iuNV96aVsZU6 /gkMT8TWXrjbY4AsoJtoSlTLx9ohvIH14PMevl0dBjCIHj1MnyKJl3dQH0pO1SEbW5 5G/ybKuTuLZCOT3/BWQZZWeknVwR+uDeBV46HgLM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dan Carpenter , "David S. Miller" , Sasha Levin Subject: [PATCH 5.10 021/151] atm: idt77252: prevent use after free in dequeue_rx() Date: Sun, 1 Sep 2024 18:16:21 +0200 Message-ID: <20240901160814.897535613@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240901160814.090297276@linuxfoundation.org> References: <20240901160814.090297276@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dan Carpenter [ Upstream commit a9a18e8f770c9b0703dab93580d0b02e199a4c79 ] We can't dereference "skb" after calling vcc->push() because the skb is released. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Dan Carpenter Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/atm/idt77252.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c index e616e33c8a209..25fd73fafb371 100644 --- a/drivers/atm/idt77252.c +++ b/drivers/atm/idt77252.c @@ -1118,8 +1118,8 @@ dequeue_rx(struct idt77252_dev *card, struct rsq_entry *rsqe) rpp->len += skb->len; if (stat & SAR_RSQE_EPDU) { + unsigned int len, truesize; unsigned char *l1l2; - unsigned int len; l1l2 = (unsigned char *) ((unsigned long) skb->data + skb->len - 6); @@ -1189,14 +1189,15 @@ dequeue_rx(struct idt77252_dev *card, struct rsq_entry *rsqe) ATM_SKB(skb)->vcc = vcc; __net_timestamp(skb); + truesize = skb->truesize; vcc->push(vcc, skb); atomic_inc(&vcc->stats->rx); - if (skb->truesize > SAR_FB_SIZE_3) + if (truesize > SAR_FB_SIZE_3) add_rx_skb(card, 3, SAR_FB_SIZE_3, 1); - else if (skb->truesize > SAR_FB_SIZE_2) + else if (truesize > SAR_FB_SIZE_2) add_rx_skb(card, 2, SAR_FB_SIZE_2, 1); - else if (skb->truesize > SAR_FB_SIZE_1) + else if (truesize > SAR_FB_SIZE_1) add_rx_skb(card, 1, SAR_FB_SIZE_1, 1); else add_rx_skb(card, 0, SAR_FB_SIZE_0, 1); -- 2.43.0