From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EEB41494DB; Thu, 5 Sep 2024 10:01:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725530507; cv=none; b=rQuRnEjoxrzb4AAf1eD1O0mNkSWslt9T4NdZa6BtFc3KD4TxG0hal8rO9zrMIiZJf4eTozyV4FbvdNwc0WvB++EYgPPXKAXxuE/hgIPxQfFByA52XtpGZ1F8DC8B64R9LN41Z6uSMnp+6b1lF9NVZtYLNxrM2iZR+s6S9qxZV3g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725530507; c=relaxed/simple; bh=JXBLMDzf4VVjWS7Q6aMvo/4OLLskozPnc6Kw8Gi+ePE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MQHZ+tP/0z6yB3RAotNTbwHPjTCQpwqCYDqZPwdKL5ncOOijd++XaUo6aDm620KoLmmDwZXOASFMJ+FKyp6ECJXEnWK54AIpJdFjxD7iuru6X+U7mg+WEFRkncp2QD/MAcj4IV5yXWlXd+1At/5W6jdOcFVTXci40peZt1SZzb4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=uICVb/Eo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="uICVb/Eo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B1DFC4CEC3; Thu, 5 Sep 2024 10:01:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1725530507; bh=JXBLMDzf4VVjWS7Q6aMvo/4OLLskozPnc6Kw8Gi+ePE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uICVb/EoIHm4TC4VQk4UuuF4Obt0sC8CeDNZoVC/hAIt7MQn2cgm4JBJNKl4Yzc4Y a1I2F3VsBpMAXVTPE1/GSLJ77bgzSwBACscFeEH5fjMQI3VwNYi0wFLxCGeswjVw6d V1uYzgavCiQSlrDM1QRk9DUmUwXUefrvAEK2o7F8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Harry Wentland , Tom Chung , Hersen Wu , Daniel Wheeler , Alex Deucher , Sasha Levin Subject: [PATCH 6.1 045/101] drm/amd/display: Fix Coverity INTEGER_OVERFLOW within dal_gpio_service_create Date: Thu, 5 Sep 2024 11:41:17 +0200 Message-ID: <20240905093717.900628286@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240905093716.075835938@linuxfoundation.org> References: <20240905093716.075835938@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Hersen Wu [ Upstream commit c6077aa66fa230d12f37fef01161ef080d13b726 ] [Why] For subtraction, coverity reports integer overflow warning message when variable type is uint32_t. [How] Change variable type to int32_t. Reviewed-by: Harry Wentland Acked-by: Tom Chung Signed-off-by: Hersen Wu Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/dc/gpio/gpio_service.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/gpio/gpio_service.c b/drivers/gpu/drm/amd/display/dc/gpio/gpio_service.c index 2f8ca831afa2..f2037d78f71a 100644 --- a/drivers/gpu/drm/amd/display/dc/gpio/gpio_service.c +++ b/drivers/gpu/drm/amd/display/dc/gpio/gpio_service.c @@ -56,7 +56,7 @@ struct gpio_service *dal_gpio_service_create( struct dc_context *ctx) { struct gpio_service *service; - uint32_t index_of_id; + int32_t index_of_id; service = kzalloc(sizeof(struct gpio_service), GFP_KERNEL); @@ -112,7 +112,7 @@ struct gpio_service *dal_gpio_service_create( return service; failure_2: - while (index_of_id) { + while (index_of_id > 0) { --index_of_id; kfree(service->busyness[index_of_id]); } -- 2.43.0