From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB62E18B487; Tue, 10 Sep 2024 09:40:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725961216; cv=none; b=GxA8XKjxAsLOOQ3W0V1ZlmB++iF+BoW4WQR80tazKIouPvsN88Kjs9tVGKH/AUP9Qw7iFYTg+duYDDtKVe+rAQXDv8RHtwtQFQ2icPBJfCmzg/0gxOKjsKwdlmX1nHaRWO0BpR/lGBVDa670wrkPKqdBSdIn1aSrPaUwP6poNnE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725961216; c=relaxed/simple; bh=hRAywrzvc2icGN6wqJjFvStiVqZs4FXiW8GdEzagOPk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GvNT1gjlpRJcTDfNoMZVlgvMgPJKFQrlPaFCbXr1Ug+7R6XoStjiD1lDWCTY1uoX1zYCw7fE8i+ec/F4q90gvaNARbNT4V90jc/WG52YNxSpTjv+ef3MQQpNHYY4gETw9J8K1anBNBIywU3F0dn3xM+s7y4+1zcCgeANupe3SYs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=zVXdj9hH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="zVXdj9hH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F77CC4CEC3; Tue, 10 Sep 2024 09:40:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1725961216; bh=hRAywrzvc2icGN6wqJjFvStiVqZs4FXiW8GdEzagOPk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zVXdj9hHmv0fhAkQyaxMxodujm1muvDYmimSUEGNgl6sWsfgKkoQdNQuLsMizmTOq oUUC7+bzndFCxtWMoU2fHVSwK9RL3+bLfnpWDJHibztbxLAaF2BKGtu28U/B+Qq5Vj 6Zx25iZLAJSj8dTcJENmo9qjqBERDHWPgKnt2tf4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Geert Uytterhoeven , Qu Wenruo , David Sterba , Sasha Levin Subject: [PATCH 4.19 66/96] btrfs: initialize location to fix -Wmaybe-uninitialized in btrfs_lookup_dentry() Date: Tue, 10 Sep 2024 11:32:08 +0200 Message-ID: <20240910092544.434648655@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240910092541.383432924@linuxfoundation.org> References: <20240910092541.383432924@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: David Sterba [ Upstream commit b8e947e9f64cac9df85a07672b658df5b2bcff07 ] Some arch + compiler combinations report a potentially unused variable location in btrfs_lookup_dentry(). This is a false alert as the variable is passed by value and always valid or there's an error. The compilers cannot probably reason about that although btrfs_inode_by_name() is in the same file. > + /kisskb/src/fs/btrfs/inode.c: error: 'location.objectid' may be used +uninitialized in this function [-Werror=maybe-uninitialized]: => 5603:9 > + /kisskb/src/fs/btrfs/inode.c: error: 'location.type' may be used +uninitialized in this function [-Werror=maybe-uninitialized]: => 5674:5 m68k-gcc8/m68k-allmodconfig mips-gcc8/mips-allmodconfig powerpc-gcc5/powerpc-all{mod,yes}config powerpc-gcc5/ppc64_defconfig Initialize it to zero, this should fix the warnings and won't change the behaviour as btrfs_inode_by_name() accepts only a root or inode item types, otherwise returns an error. Reported-by: Geert Uytterhoeven Tested-by: Geert Uytterhoeven Link: https://lore.kernel.org/linux-btrfs/bd4e9928-17b3-9257-8ba7-6b7f9bbb639a@linux-m68k.org/ Reviewed-by: Qu Wenruo Signed-off-by: David Sterba Signed-off-by: Sasha Levin --- fs/btrfs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 15ebebed4005..22059aa5eb26 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -5869,7 +5869,7 @@ struct inode *btrfs_lookup_dentry(struct inode *dir, struct dentry *dentry) struct inode *inode; struct btrfs_root *root = BTRFS_I(dir)->root; struct btrfs_root *sub_root = root; - struct btrfs_key location; + struct btrfs_key location = { 0 }; u8 di_type = 0; int index; int ret = 0; -- 2.43.0