From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4ED61DA4C; Tue, 10 Sep 2024 10:39:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725964747; cv=none; b=McMLWjloVeLWcMMroW+mTdapPC7rK8H++WYYMryK6999rku9Zpigid8JpzVvdK7d15s1ZUNrA8uG+/C4HWXCgxDQ1JNIlAAvbavJyc6NzbpwRTWJJOUchCBKzPBcXhlgIOE2FL5HOw7M2D9Wc1uP8u/2WYPkZB+J5XEniciCLeY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725964747; c=relaxed/simple; bh=0EA6lbWllFtI2hrwtFqjqSue821erJRUp0rBo7OWnM8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=F23GEuaOmU+FywFYnNWrcI4x3fGQIGlUdfR6lljQRP4RinJIJYy4nC1SyQvBonRwQohZTRVeFi074rnNzjalktvETNrpYfj0Mh1JFrlEvkuQDXbSvjLeZA4XLXTCStSheYvwvkc/+uM++VF8uzF/364x5mDScmZyYWbCF86pJUw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=wv5m2Zjx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="wv5m2Zjx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 206B1C4CEC3; Tue, 10 Sep 2024 10:39:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1725964747; bh=0EA6lbWllFtI2hrwtFqjqSue821erJRUp0rBo7OWnM8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wv5m2ZjxqiTBrBxdCwszM1ZUmb+xLt09MCDdLomUFQJuchD+j/TDODg58VJZCjPXy RR3NlEtuM04M3JuNz8zxPGgoifWGM+ZhX3DBa0YE9uNs/AkF1YiJ8KLwOIodB+sO68 UfQNQdRalQFRCfscwF7myl4y7cjcfImpxvRdFw2I= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Harry Wentland , Tom Chung , Alex Hung , Daniel Wheeler , Alex Deucher , Sasha Levin Subject: [PATCH 5.10 018/186] drm/amd/display: Check num_valid_sets before accessing reader_wm_sets[] Date: Tue, 10 Sep 2024 11:31:53 +0200 Message-ID: <20240910092555.377346735@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240910092554.645718780@linuxfoundation.org> References: <20240910092554.645718780@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Alex Hung [ Upstream commit b38a4815f79b87efb196cd5121579fc51e29a7fb ] [WHY & HOW] num_valid_sets needs to be checked to avoid a negative index when accessing reader_wm_sets[num_valid_sets - 1]. This fixes an OVERRUN issue reported by Coverity. Reviewed-by: Harry Wentland Acked-by: Tom Chung Signed-off-by: Alex Hung Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c index 0eba391e597f..40d03f8cde2c 100644 --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c @@ -455,7 +455,8 @@ static void build_watermark_ranges(struct clk_bw_params *bw_params, struct pp_sm ranges->reader_wm_sets[num_valid_sets].max_fill_clk_mhz = PP_SMU_WM_SET_RANGE_CLK_UNCONSTRAINED_MAX; /* Modify previous watermark range to cover up to max */ - ranges->reader_wm_sets[num_valid_sets - 1].max_fill_clk_mhz = PP_SMU_WM_SET_RANGE_CLK_UNCONSTRAINED_MAX; + if (num_valid_sets > 0) + ranges->reader_wm_sets[num_valid_sets - 1].max_fill_clk_mhz = PP_SMU_WM_SET_RANGE_CLK_UNCONSTRAINED_MAX; } num_valid_sets++; } -- 2.43.0