From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6621E19006F; Tue, 10 Sep 2024 10:11:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725963101; cv=none; b=kKHBpS06HkQb3ItSEVMlgyyMqTU91XQTWK0ZrTyZIi6Vcj/MhKJ/jagE1XU316ZkqarskMgv4dW3ogsCcDFzaZmu7uZEm4YzU1vQR7W9ttOL9h+zEMrOaM5zAuzN2Aqbt7qUw1PJB8wVL0BN4HoPfoMwTtio088uzg2bFCYKJEw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725963101; c=relaxed/simple; bh=7jOkney1jsfDcEbTRARLc4FJiLmQ4Zg0F/lGCcYiIQU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JZp+0TaeLPPk202LVkyC1H3xdTUddAThOv5nXxXoJe7EJa0seZ48jwywqs2QWWvjYB1ATs2Lq8FRYJESgINqopbBlb7kF3a/wAW4IOOg4zjt2zuI1DsS4muPtG6ZzSEU4bPUJL+jv0AYxBHBoNQhkHtTjTBvLcxGibu/ea8CLE8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Ic7lUK8Q; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Ic7lUK8Q" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B313C4CEC3; Tue, 10 Sep 2024 10:11:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1725963101; bh=7jOkney1jsfDcEbTRARLc4FJiLmQ4Zg0F/lGCcYiIQU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ic7lUK8QMdKk4JiDuEkl0E6/sd+9YYEtN8nklfhrOa1IMWzcZnaZgou8tV4715CQ9 BeKndessAtsTGJOcIfosYRk1HzNloe2NrtmpxZWJ8/p+m4ixOOWBGK6OweTvPd3Op6 mXDKlgGkx5fD92m8eDCZM2YvPkm0tdu8tAKSviLw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Josef Bacik , David Sterba , Sasha Levin Subject: [PATCH 6.1 109/192] btrfs: replace BUG_ON with ASSERT in walk_down_proc() Date: Tue, 10 Sep 2024 11:32:13 +0200 Message-ID: <20240910092602.481873786@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240910092557.876094467@linuxfoundation.org> References: <20240910092557.876094467@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Josef Bacik [ Upstream commit 1f9d44c0a12730a24f8bb75c5e1102207413cc9b ] We have a couple of areas where we check to make sure the tree block is locked before looking up or messing with references. This is old code so it has this as BUG_ON(). Convert this to ASSERT() for developers. Signed-off-by: Josef Bacik Reviewed-by: David Sterba Signed-off-by: David Sterba Signed-off-by: Sasha Levin --- fs/btrfs/extent-tree.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index 528cd88a77fd..d6efdcf95991 100644 --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c @@ -5200,7 +5200,7 @@ static noinline int walk_down_proc(struct btrfs_trans_handle *trans, if (lookup_info && ((wc->stage == DROP_REFERENCE && wc->refs[level] != 1) || (wc->stage == UPDATE_BACKREF && !(wc->flags[level] & flag)))) { - BUG_ON(!path->locks[level]); + ASSERT(path->locks[level]); ret = btrfs_lookup_extent_info(trans, fs_info, eb->start, level, 1, &wc->refs[level], @@ -5224,7 +5224,7 @@ static noinline int walk_down_proc(struct btrfs_trans_handle *trans, /* wc->stage == UPDATE_BACKREF */ if (!(wc->flags[level] & flag)) { - BUG_ON(!path->locks[level]); + ASSERT(path->locks[level]); ret = btrfs_inc_ref(trans, root, eb, 1); BUG_ON(ret); /* -ENOMEM */ ret = btrfs_dec_ref(trans, root, eb, 0); -- 2.43.0