From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9F271D079F; Wed, 2 Oct 2024 13:42:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727876550; cv=none; b=YuNrRAYim40rTlQtHfK9pQFhZqPCpgeHblwLcTmJS2eSGAxXa+5KskUnp9mZEr4T6YKcUn6jnasuNNtstI3WXRZIgnFwU26qxXDulUaqM6d74xWajSf+a2naknpryP3Rr1Xoxt0eRZq9qKNPgJ15qOvH5YRfAyWWcpbPvIAscvQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727876550; c=relaxed/simple; bh=/Tke32FRggsn+uYqyJ5HEB5FHoJku4ihNopH/ufbVP4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MC7xYrivG/cbFQq5xAQD0/bBKmtsEM5Bx3NCTA/EJQpoqcjzX8UFMZYiLVGOpkVeKrscrV7uVNVGlGogZOw1+BiTTT1Bv+yj652KmizrRseWOhVydf/NBJ1JyhUtsZ2MLnpNr43FOLMf78hrCgvG3dM6WsNAJKcaRBAoJN2kDRs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=VGDpVnKY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="VGDpVnKY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 619E4C4CEC5; Wed, 2 Oct 2024 13:42:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1727876550; bh=/Tke32FRggsn+uYqyJ5HEB5FHoJku4ihNopH/ufbVP4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VGDpVnKYqandgaYaZBdwYmwgf2gnwaKwq2wHkLim4j8klZ1C2McN440T+WQtAO1gO 1DSsd5PY99Uq/RL5QldVHo4oGXCxkl3HfR3pK7YAGpNsZCxUBPACGOB61Zlen/gJeq VvOkE6WkpWND4gJrkP7HzRLo+X3gcK7WwzcjgcUk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Youssef Samir , Jeffery Hugo , Carl Vanderlip , Chris Lew , Paolo Abeni , Sasha Levin Subject: [PATCH 6.11 482/695] net: qrtr: Update packets cloning when broadcasting Date: Wed, 2 Oct 2024 14:58:00 +0200 Message-ID: <20241002125841.710582769@linuxfoundation.org> X-Mailer: git-send-email 2.46.2 In-Reply-To: <20241002125822.467776898@linuxfoundation.org> References: <20241002125822.467776898@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.11-stable review patch. If anyone has any objections, please let me know. ------------------ From: Youssef Samir [ Upstream commit f011b313e8ebd5b7abd8521b5119aecef403de45 ] When broadcasting data to multiple nodes via MHI, using skb_clone() causes all nodes to receive the same header data. This can result in packets being discarded by endpoints, leading to lost data. This issue occurs when a socket is closed, and a QRTR_TYPE_DEL_CLIENT packet is broadcasted. All nodes receive the same destination node ID, causing the node connected to the client to discard the packet and remain unaware of the client's deletion. Replace skb_clone() with pskb_copy(), to create a separate copy of the header for each sk_buff. Fixes: bdabad3e363d ("net: Add Qualcomm IPC router") Signed-off-by: Youssef Samir Reviewed-by: Jeffery Hugo Reviewed-by: Carl Vanderlip Reviewed-by: Chris Lew Link: https://patch.msgid.link/20240916170858.2382247-1-quic_yabdulra@quicinc.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- net/qrtr/af_qrtr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/qrtr/af_qrtr.c b/net/qrtr/af_qrtr.c index 41ece61eb57ab..00c51cf693f3d 100644 --- a/net/qrtr/af_qrtr.c +++ b/net/qrtr/af_qrtr.c @@ -884,7 +884,7 @@ static int qrtr_bcast_enqueue(struct qrtr_node *node, struct sk_buff *skb, mutex_lock(&qrtr_node_lock); list_for_each_entry(node, &qrtr_all_nodes, item) { - skbn = skb_clone(skb, GFP_KERNEL); + skbn = pskb_copy(skb, GFP_KERNEL); if (!skbn) break; skb_set_owner_w(skbn, skb->sk); -- 2.43.0