From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C49329CE7; Wed, 2 Oct 2024 13:53:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727877180; cv=none; b=igPrRZA6GzdYsjzxZIaODaQvdUocHw8H+uOtsEFdH6+Z2QPyT/sUFIjP4TPUBOz9EJ8OI1SQeXy71cDvrVqCsiis3qRFFvzk82gTpg58ymXkZAsTKw4I9LBcxsOnkLr1ht7uJ4VI4o5U8FAcbAxscNmjocP2s9tuOVqqpWqkK9U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727877180; c=relaxed/simple; bh=X1T+FQ7IG+XeXk90Y2yiwrineC93QOl5rZDcAcsl/Rk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=d9Ib8wDVBrih4BWxdXScEsMDTkTjVzqJv7bYfbjx7DkM74336lUZLqM32ZK6BDnbmi9XGMoPIVDw68MaDL+72nTR5yZHLQBC7uizpv94LgO339OMaAj45XskLA3IcyBl457i2cM/89yFeoQHVaBId7AgiTYPtSqTLaM73Z9K3RM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=D/h7TxxD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="D/h7TxxD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C66F9C4CEC5; Wed, 2 Oct 2024 13:52:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1727877180; bh=X1T+FQ7IG+XeXk90Y2yiwrineC93QOl5rZDcAcsl/Rk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D/h7TxxDfsSui830zal9cS1m7pWBmrbqr0NMC5NbdHXDRXYZgdk+emUaYgTv8EC3Z si7EVtY/mAEa1Js3c4QGSnZ6aM57RpqpcAanT9G7gtUxyARSPpISKgtHCAEw2s1QlX 6r5dFZI3vW+VHbBCiWyVITs3kDW5ajsi9EQwn9p4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, "Liam R. Howlett" , SeongJae Park , Guenter Roeck , David Hildenbrand , Matthew Wilcox , Andrew Morton Subject: [PATCH 6.11 690/695] mm/damon/vaddr: protect vma traversal in __damon_va_thre_regions() with rcu read lock Date: Wed, 2 Oct 2024 15:01:28 +0200 Message-ID: <20241002125850.063402042@linuxfoundation.org> X-Mailer: git-send-email 2.46.2 In-Reply-To: <20241002125822.467776898@linuxfoundation.org> References: <20241002125822.467776898@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.11-stable review patch. If anyone has any objections, please let me know. ------------------ From: Liam R. Howlett commit fb497d6db7c19c797cbd694b52d1af87c4eebcc6 upstream. Traversing VMAs of a given maple tree should be protected by rcu read lock. However, __damon_va_three_regions() is not doing the protection. Hold the lock. Link: https://lkml.kernel.org/r/20240905001204.1481-1-sj@kernel.org Fixes: d0cf3dd47f0d ("damon: convert __damon_va_three_regions to use the VMA iterator") Signed-off-by: Liam R. Howlett Signed-off-by: SeongJae Park Reported-by: Guenter Roeck Closes: https://lore.kernel.org/b83651a0-5b24-4206-b860-cb54ffdf209b@roeck-us.net Tested-by: Guenter Roeck Cc: David Hildenbrand Cc: Matthew Wilcox Cc: Signed-off-by: Andrew Morton Signed-off-by: Greg Kroah-Hartman --- mm/damon/vaddr.c | 2 ++ 1 file changed, 2 insertions(+) --- a/mm/damon/vaddr.c +++ b/mm/damon/vaddr.c @@ -126,6 +126,7 @@ static int __damon_va_three_regions(stru * If this is too slow, it can be optimised to examine the maple * tree gaps. */ + rcu_read_lock(); for_each_vma(vmi, vma) { unsigned long gap; @@ -146,6 +147,7 @@ static int __damon_va_three_regions(stru next: prev = vma; } + rcu_read_unlock(); if (!sz_range(&second_gap) || !sz_range(&first_gap)) return -EINVAL;