From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52E6D1DEFDD; Tue, 8 Oct 2024 13:14:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728393280; cv=none; b=vBYvO7UVrIQNSlZ2qE6jQPwowYBsWqdyB+QvTb/qg94fXgtA/Jz3/w47Ah3Wp5Kf+Bmu4HIGbGBbcB44fKlItmiPQpkuWj5ckf0dbHDYqMwhtQNxfiJT7Kgo1HdUmMle7euYYgSFcmqzLGsiHG/jW5mGJ5KG0NXmznJ1FQw+Cok= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728393280; c=relaxed/simple; bh=6v7/FTXG/rs555X1JWMoFNRxv/eV5Wk/JJUmT/2VdS4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kkT8MKykXLBaE/F309wI9RRPKrkJW2u/7cUIgCbrM7g5NwAOPLM2nZ5BdeQFIaDjdroz1OBp8yUPsLawDtg2339rvr7Q/s8N0TgFVrC4+AmwMXSU8lQ650snDGJ6DqL7wVFZzo6p0cNBKEorTMSIBtHVH+A5OxOjPnzqSZfAs18= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=CYUENVp2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="CYUENVp2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA097C4CECC; Tue, 8 Oct 2024 13:14:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728393280; bh=6v7/FTXG/rs555X1JWMoFNRxv/eV5Wk/JJUmT/2VdS4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CYUENVp2lohZM1a3vgt0JT934YeBbk+pcEDk1uECg9kEEjhi/BR/4ExEnEjSoT544 sUszF1VqPeY1fSHvW7FFbTEkgEdoGjLKzWoCQx5xjMlT532DuZHQ8/JIgIhzq9XG/7 fmrPTedQer/J1aqsN1vTYvB8WffD639KU3+/FjOs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Louis Peens , Jinjie Ruan , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.6 106/386] nfp: Use IRQF_NO_AUTOEN flag in request_irq() Date: Tue, 8 Oct 2024 14:05:51 +0200 Message-ID: <20241008115633.615685831@linuxfoundation.org> X-Mailer: git-send-email 2.46.2 In-Reply-To: <20241008115629.309157387@linuxfoundation.org> References: <20241008115629.309157387@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jinjie Ruan [ Upstream commit daaba19d357f0900b303a530ced96c78086267ea ] disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable when request IRQ. Reviewed-by: Louis Peens Signed-off-by: Jinjie Ruan Link: https://patch.msgid.link/20240911094445.1922476-4-ruanjinjie@huawei.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c index f2085340a1cfe..fceb4abea2365 100644 --- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c @@ -821,14 +821,13 @@ nfp_net_prepare_vector(struct nfp_net *nn, struct nfp_net_r_vector *r_vec, snprintf(r_vec->name, sizeof(r_vec->name), "%s-rxtx-%d", nfp_net_name(nn), idx); - err = request_irq(r_vec->irq_vector, r_vec->handler, 0, r_vec->name, - r_vec); + err = request_irq(r_vec->irq_vector, r_vec->handler, IRQF_NO_AUTOEN, + r_vec->name, r_vec); if (err) { nfp_net_napi_del(&nn->dp, r_vec); nn_err(nn, "Error requesting IRQ %d\n", r_vec->irq_vector); return err; } - disable_irq(r_vec->irq_vector); irq_set_affinity_hint(r_vec->irq_vector, &r_vec->affinity_mask); -- 2.43.0