From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A33C192594; Tue, 8 Oct 2024 13:15:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728393330; cv=none; b=gu+P9KqrsBhtT2kTc2yzRU2uRj8EO46BXWcdKTP+mQu5zWxxtskZCd7Sz39DGTPY59ieNnQeW8fteWJe3+bnVJV5Fq2ZFtgRDxDDt1eZfUJjM/b3sxeCQG9KMjWTYm2nKMA4HURpIDoAWuh/UdWZUWROblpUsHjYUArTyZqjCPE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728393330; c=relaxed/simple; bh=KF5onVzPk939l8uXDiJ4T3rge6xXS4V5bJIVKuTL2ek=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DkvqNgpqdivz9eNAhEW4oLgELjO4RHYXEH2WjzFFFH7sPrOYTk/npvyhl1YXE9oiFPgoJoTUl3I862KNjlkLX9dQkDoQBDqg/v1UGl9d0PgfRKtI/Ox84zgngD4vg/Y7oj/ryhLfOHgKcKDOBJk6acjScAhK0a0mozq5NNDCdwk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=AF4+bgww; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="AF4+bgww" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6CB5C4CECC; Tue, 8 Oct 2024 13:15:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728393330; bh=KF5onVzPk939l8uXDiJ4T3rge6xXS4V5bJIVKuTL2ek=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AF4+bgww/36NFSwmNAEJHa1EvVGUtA8WDuCNBmq89dAiYxErixf5xb3lSmOqB67LH Lwc/lnY966eHvsDACu6+s3waMyqwhPCN4V73Fhja3jxY7w2fzfTUHrpX1F750vW+DB rQijzuVwN56eEyO7/ZilcSgrwsrO76JZr+nyua5M= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Takashi Iwai , Sasha Levin Subject: [PATCH 6.6 118/386] ALSA: asihpi: Fix potential OOB array access Date: Tue, 8 Oct 2024 14:06:03 +0200 Message-ID: <20241008115634.084204053@linuxfoundation.org> X-Mailer: git-send-email 2.46.2 In-Reply-To: <20241008115629.309157387@linuxfoundation.org> References: <20241008115629.309157387@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Takashi Iwai [ Upstream commit 7b986c7430a6bb68d523dac7bfc74cbd5b44ef96 ] ASIHPI driver stores some values in the static array upon a response from the driver, and its index depends on the firmware. We shouldn't trust it blindly. This patch adds a sanity check of the array index to fit in the array size. Link: https://patch.msgid.link/20240808091454.30846-1-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/pci/asihpi/hpimsgx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/asihpi/hpimsgx.c b/sound/pci/asihpi/hpimsgx.c index d0caef2994818..b68e6bfbbfbab 100644 --- a/sound/pci/asihpi/hpimsgx.c +++ b/sound/pci/asihpi/hpimsgx.c @@ -708,7 +708,7 @@ static u16 HPIMSGX__init(struct hpi_message *phm, phr->error = HPI_ERROR_PROCESSING_MESSAGE; return phr->error; } - if (hr.error == 0) { + if (hr.error == 0 && hr.u.s.adapter_index < HPI_MAX_ADAPTERS) { /* the adapter was created successfully save the mapping for future use */ hpi_entry_points[hr.u.s.adapter_index] = entry_point_func; -- 2.43.0