From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3A071D618C; Tue, 8 Oct 2024 12:14:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728389646; cv=none; b=i5GaZQLDxUTWmdFfuvP4gdQp8n4xtrSkTiG9lUIKOj7KH/1mSQRY+4GMgeh9+g1OIWTblPYJh1tyCaw5C56NHP2TyzWqK+ddMykjEnfgLvFNcXfOl13WRDbN9WLQuJKxTEckuDG9D2CDOWRzKTsHcXkP/LyeTrNiD2db+qBPNfc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728389646; c=relaxed/simple; bh=qgLay9iYLWbc8RTFHhaX5JzOsc4yKR0XwtgW2H1FK2Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gfV603B145MkU473kChrm8e1JYBVP11b1jsjAqofrLCcsz/FriAQZCd704Kk2U2gXFHwD1OipS7CI3P9E6Mofs2RSwC0woObwu/VZv1LfUkgfhFcDUpDcUCs6OLMtuDZNEQZCc9+2rMSfL4uYuYPe7jjj9Tv9DLetijD4onr0do= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=VzT493vx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="VzT493vx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1A40C4CEC7; Tue, 8 Oct 2024 12:14:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728389646; bh=qgLay9iYLWbc8RTFHhaX5JzOsc4yKR0XwtgW2H1FK2Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VzT493vxwfamfTE9qHHo+eLIt6poSq3CKHMoriBXzC4saXSBUBOD/BEoYbqC99aPW bBGbfV9+4f78cbUSUzb4SCItZX1ZuhNbS751T7CmNaXfNXi2MY8x3LDehHKtPXbH5F /9iZPwyGU0CoGzuVYiRuhvUWIW8uiXG28+6brH+Q= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Miquel Raynal , Jinjie Ruan , Stefan Schmidt , Sasha Levin Subject: [PATCH 6.10 023/482] net: ieee802154: mcr20a: Use IRQF_NO_AUTOEN flag in request_irq() Date: Tue, 8 Oct 2024 14:01:26 +0200 Message-ID: <20241008115649.212007447@linuxfoundation.org> X-Mailer: git-send-email 2.46.2 In-Reply-To: <20241008115648.280954295@linuxfoundation.org> References: <20241008115648.280954295@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jinjie Ruan [ Upstream commit 09573b1cc76e7ff8f056ab29ea1cdc152ec8c653 ] disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable when request IRQ. Fixes: 8c6ad9cc5157 ("ieee802154: Add NXP MCR20A IEEE 802.15.4 transceiver driver") Reviewed-by: Miquel Raynal Signed-off-by: Jinjie Ruan Link: https://lore.kernel.org/20240911094234.1922418-1-ruanjinjie@huawei.com Signed-off-by: Stefan Schmidt Signed-off-by: Sasha Levin --- drivers/net/ieee802154/mcr20a.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ieee802154/mcr20a.c b/drivers/net/ieee802154/mcr20a.c index 433fb58392031..020d392a98b69 100644 --- a/drivers/net/ieee802154/mcr20a.c +++ b/drivers/net/ieee802154/mcr20a.c @@ -1302,16 +1302,13 @@ mcr20a_probe(struct spi_device *spi) irq_type = IRQF_TRIGGER_FALLING; ret = devm_request_irq(&spi->dev, spi->irq, mcr20a_irq_isr, - irq_type, dev_name(&spi->dev), lp); + irq_type | IRQF_NO_AUTOEN, dev_name(&spi->dev), lp); if (ret) { dev_err(&spi->dev, "could not request_irq for mcr20a\n"); ret = -ENODEV; goto free_dev; } - /* disable_irq by default and wait for starting hardware */ - disable_irq(spi->irq); - ret = ieee802154_register_hw(hw); if (ret) { dev_crit(&spi->dev, "ieee802154_register_hw failed\n"); -- 2.43.0