From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E96EC18FC70; Tue, 8 Oct 2024 12:18:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728389921; cv=none; b=ZxdmoyNG6EzBE4RgyRN5oD/jhjuSMLXXPk+o9LuY/gIYdtiTt6ahnBQ8yCTfJkv9zW+bXm9iFMOBaG7LpS6XzAbgRvTJnj/pJ54EwSP5C/KM0cuUC6fDNwTZiP12R+RCzH3/Npt8L2ZCHD3ZlcdWYoyebqx6QKH00evMjdlyHL8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728389921; c=relaxed/simple; bh=akpvxJ+9Krvy0FlkNrSdNHEgL09iwZgKKJpYOHPmIiY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B7DVOOvxyNer7p/tD6aOExbFRRFNCLB/i3fxHx4nb1D9B90NG2i58HDRJXt19KgLX9kiivqZRSndmIJZlXEhA8OghNDY9R2/l3M39Vd8LE67SZrmhfqYpCSTr2MNa3lao+3g8R7m26bh204FLh4pZgPTBaUvBXwD9hogdCo2LwM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=d4gVg5bl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="d4gVg5bl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59C33C4CEC7; Tue, 8 Oct 2024 12:18:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728389920; bh=akpvxJ+9Krvy0FlkNrSdNHEgL09iwZgKKJpYOHPmIiY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d4gVg5bl8pzc+GdBH72b9BPNAGwN5TAQnRwTw3boGti6UVq7gIDysLi+e8kRB27MP CcQWIPJAMBZ/k7vZx4RSXprWmMMcB0p1WJkxG440lbpNBMd0MIRLS4YlNpvlLVMyV2 F8Zl12tTaHWaWMzVjuMZ/PejdYie2MgdLvp1K8so= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Louis Peens , Jinjie Ruan , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.10 137/482] nfp: Use IRQF_NO_AUTOEN flag in request_irq() Date: Tue, 8 Oct 2024 14:03:20 +0200 Message-ID: <20241008115653.695927671@linuxfoundation.org> X-Mailer: git-send-email 2.46.2 In-Reply-To: <20241008115648.280954295@linuxfoundation.org> References: <20241008115648.280954295@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jinjie Ruan [ Upstream commit daaba19d357f0900b303a530ced96c78086267ea ] disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable when request IRQ. Reviewed-by: Louis Peens Signed-off-by: Jinjie Ruan Link: https://patch.msgid.link/20240911094445.1922476-4-ruanjinjie@huawei.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c index 182ba0a8b095b..6e0929af0f725 100644 --- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c @@ -821,14 +821,13 @@ nfp_net_prepare_vector(struct nfp_net *nn, struct nfp_net_r_vector *r_vec, snprintf(r_vec->name, sizeof(r_vec->name), "%s-rxtx-%d", nfp_net_name(nn), idx); - err = request_irq(r_vec->irq_vector, r_vec->handler, 0, r_vec->name, - r_vec); + err = request_irq(r_vec->irq_vector, r_vec->handler, IRQF_NO_AUTOEN, + r_vec->name, r_vec); if (err) { nfp_net_napi_del(&nn->dp, r_vec); nn_err(nn, "Error requesting IRQ %d\n", r_vec->irq_vector); return err; } - disable_irq(r_vec->irq_vector); irq_set_affinity_hint(r_vec->irq_vector, &r_vec->affinity_mask); -- 2.43.0