From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A6C81DE2CF; Tue, 8 Oct 2024 12:52:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728391957; cv=none; b=L4UXU/2+bbvSuNr1rHTUcjMX6Ekl0kOsMX/Nw9AiFpVxHAmydZ/QOrL73rLueHN9GalXurSLkyp8cBy5QhX4cWAWY+3sX4EMGtBqLeY1yIS74UOhuKjEOMKAkH80CLDvNwqMMSEOfD5WI8NcXKDd5SCOwtHaZd+JHEoXcbFbVag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728391957; c=relaxed/simple; bh=uDu1vKbqHyoUsLQCh0bc86HH8hEu2Fw6naJpV8hcNWc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sJj+ZF6dQJ0Y0bJvOS83rHbvMExbxrdOPojrb46cWDZtEr+Rtuuews4E0xgZJb4XulvKxe1mnCJqCeUjF85JtUmEy01XTWYyQFOhcewK3/VAGlWBkRoRru9EkmkIKRNyo7RrPQErF9ivzvkzIOrw6Tm8jrsJgFEiTF83toq7Q94= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=H1+ZjO2t; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="H1+ZjO2t" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E73FC4CEC7; Tue, 8 Oct 2024 12:52:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728391957; bh=uDu1vKbqHyoUsLQCh0bc86HH8hEu2Fw6naJpV8hcNWc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H1+ZjO2tQfEJ06guXyV5OjZDfE28AdD7sjY2IIT5EDOyeBjv/FwpECZuXBx3CimJX +s5oa8M7BSqI/dI4GC9WS4ZrwgG9uKOjeMPJzJOCOTUh5xNA4rWqGrYAAnJvURuSwC AtMny6X1OOsLhjNa910POoWeVcApwR3wbxjbVAlY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+02341e0daa42a15ce130@syzkaller.appspotmail.com, Zhao Mengmeng , Dave Kleikamp , Sasha Levin Subject: [PATCH 6.11 242/558] jfs: Fix uninit-value access of new_ea in ea_buffer Date: Tue, 8 Oct 2024 14:04:32 +0200 Message-ID: <20241008115711.864217899@linuxfoundation.org> X-Mailer: git-send-email 2.46.2 In-Reply-To: <20241008115702.214071228@linuxfoundation.org> References: <20241008115702.214071228@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.11-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zhao Mengmeng [ Upstream commit 2b59ffad47db1c46af25ccad157bb3b25147c35c ] syzbot reports that lzo1x_1_do_compress is using uninit-value: ===================================================== BUG: KMSAN: uninit-value in lzo1x_1_do_compress+0x19f9/0x2510 lib/lzo/lzo1x_compress.c:178 ... Uninit was stored to memory at: ea_put fs/jfs/xattr.c:639 [inline] ... Local variable ea_buf created at: __jfs_setxattr+0x5d/0x1ae0 fs/jfs/xattr.c:662 __jfs_xattr_set+0xe6/0x1f0 fs/jfs/xattr.c:934 ===================================================== The reason is ea_buf->new_ea is not initialized properly. Fix this by using memset to empty its content at the beginning in ea_get(). Reported-by: syzbot+02341e0daa42a15ce130@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=02341e0daa42a15ce130 Signed-off-by: Zhao Mengmeng Signed-off-by: Dave Kleikamp Signed-off-by: Sasha Levin --- fs/jfs/xattr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/jfs/xattr.c b/fs/jfs/xattr.c index 2999ed5d83f5e..0fb05e314edf6 100644 --- a/fs/jfs/xattr.c +++ b/fs/jfs/xattr.c @@ -434,6 +434,8 @@ static int ea_get(struct inode *inode, struct ea_buffer *ea_buf, int min_size) int rc; int quota_allocation = 0; + memset(&ea_buf->new_ea, 0, sizeof(ea_buf->new_ea)); + /* When fsck.jfs clears a bad ea, it doesn't clear the size */ if (ji->ea.flag == 0) ea_size = 0; -- 2.43.0