From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4BD41BDAB9; Mon, 14 Oct 2024 14:56:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728917787; cv=none; b=ZNDCknYEPf5nwAE5G4DaL5gIdFCnRh0IGjtG8aG+Zjl47x5nZlNX8irto6T9Ez+wdJ3Idh1Bg4BlqhjOQUZ0nLPhbGTRFabNdCISy/ANR45OKzU45RLjNWEXn+EpQ8VIbL/FN0PpgBcTxv+Vr/+NXuo9iiXKVfh+C7M6nSlNDg0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728917787; c=relaxed/simple; bh=0h9bOWpH/YiczRY16r3i+jtnQjpVLT1heLRwxmt2zbI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rFVjL2mJjXGHLWvYBzWWalfhsy7BlCNTt8ZXlajF2/Z0Cj1rpVvcsv5F4Jktfho9H59DDx6dck+yf/iM7Mr7Kp2GhnMJQLt7DzpybP4FLQUsR6vj2bLFN3Jzot/AKzNL8gPQyniCJVHzr1+3iUeUTaPuJ7JpNqAywCKBmgbBLc8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=cmUZCm3B; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="cmUZCm3B" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08E75C4CEC3; Mon, 14 Oct 2024 14:56:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728917787; bh=0h9bOWpH/YiczRY16r3i+jtnQjpVLT1heLRwxmt2zbI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cmUZCm3BlSAtb1xtOVlbbubrF3kK7EQ8rCoJmKcEE75xx9La1/+1VQPEzYrWkdkyF RzB3x42bETOrSTyw4SE+es0NT2t5UuYDtZmL2f+5zYA8ZcaSoGj7IL9gmGjqg8jzBb bGsidWD40dyeWvtHXJ2sywLcSa6Fz2kU6WKbC4dY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Juergen Gross , Stefano Stabellini , Sasha Levin Subject: [PATCH 6.1 135/798] xen/swiotlb: add alignment check for dma buffers Date: Mon, 14 Oct 2024 16:11:29 +0200 Message-ID: <20241014141223.223663091@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241014141217.941104064@linuxfoundation.org> References: <20241014141217.941104064@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Juergen Gross [ Upstream commit 9f40ec84a7976d95c34e7cc070939deb103652b0 ] When checking a memory buffer to be consecutive in machine memory, the alignment needs to be checked, too. Failing to do so might result in DMA memory not being aligned according to its requested size, leading to error messages like: 4xxx 0000:2b:00.0: enabling device (0140 -> 0142) 4xxx 0000:2b:00.0: Ring address not aligned 4xxx 0000:2b:00.0: Failed to initialise service qat_crypto 4xxx 0000:2b:00.0: Resetting device qat_dev0 4xxx: probe of 0000:2b:00.0 failed with error -14 Fixes: 9435cce87950 ("xen/swiotlb: Add support for 64KB page granularity") Signed-off-by: Juergen Gross Reviewed-by: Stefano Stabellini Signed-off-by: Juergen Gross Signed-off-by: Sasha Levin --- drivers/xen/swiotlb-xen.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c index 7290f2b402e2a..cf52964f057b3 100644 --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -78,9 +78,15 @@ static inline int range_straddles_page_boundary(phys_addr_t p, size_t size) { unsigned long next_bfn, xen_pfn = XEN_PFN_DOWN(p); unsigned int i, nr_pages = XEN_PFN_UP(xen_offset_in_page(p) + size); + phys_addr_t algn = 1ULL << (get_order(size) + PAGE_SHIFT); next_bfn = pfn_to_bfn(xen_pfn); + /* If buffer is physically aligned, ensure DMA alignment. */ + if (IS_ALIGNED(p, algn) && + !IS_ALIGNED((phys_addr_t)next_bfn << XEN_PAGE_SHIFT, algn)) + return 1; + for (i = 1; i < nr_pages; i++) if (pfn_to_bfn(++xen_pfn) != ++next_bfn) return 1; -- 2.43.0