From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E603C55896; Mon, 14 Oct 2024 15:07:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728918449; cv=none; b=GKWdQGLXfilsGgotOrph4YdTUcZTvi5T9oOr0eS/3WIaZyc2Gr3kGB5kysQn4qfbCSmeeUvdfAnn9BKNKPU6Ss35OO8WJNn6jMtuOcualwWbkSDi0/ZKBKBpugJFZjYlNT4yMk0AvHldLei/hNCO5XFLYAICw7FqeGSnbdpshZc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728918449; c=relaxed/simple; bh=MlwOfZLuXMhPdHDdqW7Byq73vB9yNWX6j0iSsRwZYCM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HMmZq2JNncRpQKVT6oZ3yeRcPaCwJsL2VqeJ43S/oCSEx1bCuGujMcSHQzRA7SPFpu2nVwcEnomx+N3XXtxR07kgf72hBFuqhlpgupxTmYUIo7Juu71akClczifmHwXB1Tf7XHuvq9pN8RiBwoxhefUOTLfaxLA3JLHzNtcc8vk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=t28Cx7Mk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="t28Cx7Mk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E078C4CED0; Mon, 14 Oct 2024 15:07:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728918448; bh=MlwOfZLuXMhPdHDdqW7Byq73vB9yNWX6j0iSsRwZYCM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=t28Cx7Mkkutf/GT7gYMJgv9tcasEidG25SDp/P2E+J8t136mYIiVBjW8bJbZGNpLx h4AgtyrOzbiX08qiRjdVDZBZlhefvRfOo9Abqr3iLJVCAPnkqnSgavqTTYm+y4uINZ kOVv8bnzcBAAwr7PFZZxdr5T0x2U2mmGlyFgHI+g= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Harry Wentland , Mario Limonciello , Alex Deucher Subject: [PATCH 6.1 295/798] drm/amd/display: Validate backlight caps are sane Date: Mon, 14 Oct 2024 16:14:09 +0200 Message-ID: <20241014141229.531753956@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241014141217.941104064@linuxfoundation.org> References: <20241014141217.941104064@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mario Limonciello commit 327e62f47eb57ae5ff63de82b0815557104e439a upstream. Currently amdgpu takes backlight caps provided by the ACPI tables on systems as is. If the firmware sets maximums that are too low this means that users don't get a good experience. To avoid having to maintain a quirk list of such systems, do a sanity check on the values. Check that the spread is at least half of the values that amdgpu would use if no ACPI table was found and if not use the amdgpu defaults. Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3020 Reviewed-by: Harry Wentland Signed-off-by: Mario Limonciello Signed-off-by: Alex Deucher Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -4050,6 +4050,7 @@ static int amdgpu_dm_mode_config_init(st #define AMDGPU_DM_DEFAULT_MIN_BACKLIGHT 12 #define AMDGPU_DM_DEFAULT_MAX_BACKLIGHT 255 +#define AMDGPU_DM_MIN_SPREAD ((AMDGPU_DM_DEFAULT_MAX_BACKLIGHT - AMDGPU_DM_DEFAULT_MIN_BACKLIGHT) / 2) #define AUX_BL_DEFAULT_TRANSITION_TIME_MS 50 static void amdgpu_dm_update_backlight_caps(struct amdgpu_display_manager *dm, @@ -4064,6 +4065,21 @@ static void amdgpu_dm_update_backlight_c return; amdgpu_acpi_get_backlight_caps(&caps); + + /* validate the firmware value is sane */ + if (caps.caps_valid) { + int spread = caps.max_input_signal - caps.min_input_signal; + + if (caps.max_input_signal > AMDGPU_DM_DEFAULT_MAX_BACKLIGHT || + caps.min_input_signal < AMDGPU_DM_DEFAULT_MIN_BACKLIGHT || + spread > AMDGPU_DM_DEFAULT_MAX_BACKLIGHT || + spread < AMDGPU_DM_MIN_SPREAD) { + DRM_DEBUG_KMS("DM: Invalid backlight caps: min=%d, max=%d\n", + caps.min_input_signal, caps.max_input_signal); + caps.caps_valid = false; + } + } + if (caps.caps_valid) { dm->backlight_caps[bl_idx].caps_valid = true; if (caps.aux_support)