From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C1071EBA09; Tue, 15 Oct 2024 11:41:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728992490; cv=none; b=lDc7SfiPL44WFeCmIlVxZI/zKI3iArZpx9aC10Qo7xVyGMxwi1JvtU6a+wfPdiB8XP/tlb+WeRav5SFUaLfv+NZJpzvkeJs2qeTzcDFtY8c/C10el1LCoQVejZ1j2YmnAX5V0Suo7UMSLOrfgNib2UvOuuSb/AL8YrSyUqekCd8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728992490; c=relaxed/simple; bh=fu/ODt8V25wiGugm5YNQyiLLmOuMD8giuWS9VUBNrB0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mnezotdLAxQNYiJLKXCawPc+n8tD45q4sRmKkhX88ExjmQpbEg6hCccSvAQIad8+J7PCzkIwWr9V9MSafw4MyufTKikmoTHRPlIm6ykLcZ/VxgubcrqSk7/bSd7d9wAuFozWRIQnI+c5B3N0ep6bbObgD7A2DOU8MVnCGL9ufXg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=XCVKOg6C; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="XCVKOg6C" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3154C4CECF; Tue, 15 Oct 2024 11:41:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728992490; bh=fu/ODt8V25wiGugm5YNQyiLLmOuMD8giuWS9VUBNrB0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XCVKOg6CZWpsEJaw5XJgc/Bme547/LrOVXAEqy00jFR2Vj4/BUtQJQMA56xw9HNmK xu0LPNFadj2iLqH6c0ioZogTFaAzObQmRY+tNCMVLg768MUQ56fLc6DMgKSceIJ0L7 emccJozJ2QtlfYsryudZtYbxq15wt9Io6HzWUvkw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jinjie Ruan , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.15 130/691] net: enetc: Use IRQF_NO_AUTOEN flag in request_irq() Date: Tue, 15 Oct 2024 13:21:18 +0200 Message-ID: <20241015112445.516418749@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241015112440.309539031@linuxfoundation.org> References: <20241015112440.309539031@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jinjie Ruan [ Upstream commit 799a9225997799f7b1b579bc50a93b78b4fb2a01 ] disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable when request IRQ. Fixes: bbb96dc7fa1a ("enetc: Factor out the traffic start/stop procedures") Signed-off-by: Jinjie Ruan Link: https://patch.msgid.link/20240911094445.1922476-3-ruanjinjie@huawei.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/freescale/enetc/enetc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/ethernet/freescale/enetc/enetc.c index e16bd2b7692f3..9e063eb17f527 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc.c +++ b/drivers/net/ethernet/freescale/enetc/enetc.c @@ -1883,12 +1883,11 @@ static int enetc_setup_irqs(struct enetc_ndev_priv *priv) snprintf(v->name, sizeof(v->name), "%s-rxtx%d", priv->ndev->name, i); - err = request_irq(irq, enetc_msix, 0, v->name, v); + err = request_irq(irq, enetc_msix, IRQF_NO_AUTOEN, v->name, v); if (err) { dev_err(priv->dev, "request_irq() failed!\n"); goto irq_err; } - disable_irq(irq); v->tbier_base = hw->reg + ENETC_BDR(TX, 0, ENETC_TBIER); v->rbier = hw->reg + ENETC_BDR(RX, i, ENETC_RBIER); -- 2.43.0