From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 803451D90CD; Tue, 15 Oct 2024 11:44:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728992654; cv=none; b=eh5L6dMFT99Twqv1guv16ckyBvykJ90N/h7w6DGcvEUuZ+O3194UxB7EPBV8pLEmIgvIRuVe/E3DVzacBSDS7F6bRL7YKDUi9Y8dJqf168WOpSVVi1un35kczq0xgU8ipxeF/KtgRywlEfI7wAb4nIKQaygAeLMEhtkOJdx0brI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728992654; c=relaxed/simple; bh=cO4EA9w4AlVQwzpqW4QAtVRm4PkSUXl9jIyky/SfvPc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fzl25ZNcy5t3x4CMwfxQ+itu09GsVS/rFUat0rJzLB/SIJanGI+MXXBnG0gVhZcPsNpSuorUAz4hisrh3WvJ9H0Ck5VNonCEPRyJzIlozw2fTVyjBjQAwajrmkdbCTrWfpmwC9VrnqI48vATHA4hsdkrynI50B6SvrsRVY05F0E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=VouGdJlX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="VouGdJlX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5B97C4CEC6; Tue, 15 Oct 2024 11:44:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728992654; bh=cO4EA9w4AlVQwzpqW4QAtVRm4PkSUXl9jIyky/SfvPc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VouGdJlXjAYNG1/SHhELkTPO2+lsIf6+2jOf84v047aNF9Z/BK19AG1oIvyO806bO 7sXaNV2dEbJWaqY0t+BOQMVMF1O1y8K3Wf3g61YC+gvbr6EAx2a2gJEEbJD4vPQW0T 1G8/qO+HTdGp2yRMWqYOLmVHgMy1UesAqWTu0bHg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Stan Johnson , Finn Thain , Geert Uytterhoeven , Sasha Levin Subject: [PATCH 5.15 148/691] m68k: Fix kernel_clone_args.flags in m68k_clone() Date: Tue, 15 Oct 2024 13:21:36 +0200 Message-ID: <20241015112446.227206057@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241015112440.309539031@linuxfoundation.org> References: <20241015112440.309539031@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Finn Thain [ Upstream commit 09b3d870faa7bc3e96c0978ab3cf4e96e4b15571 ] Stan Johnson recently reported a failure from the 'dump' command: DUMP: Date of this level 0 dump: Fri Aug 9 23:37:15 2024 DUMP: Dumping /dev/sda (an unlisted file system) to /dev/null DUMP: Label: none DUMP: Writing 10 Kilobyte records DUMP: mapping (Pass I) [regular files] DUMP: mapping (Pass II) [directories] DUMP: estimated 3595695 blocks. DUMP: Context save fork fails in parent 671 The dump program uses the clone syscall with the CLONE_IO flag, that is, flags == 0x80000000. When that value is promoted from long int to u64 by m68k_clone(), it undergoes sign-extension. The new value includes CLONE_INTO_CGROUP so the validation in cgroup_css_set_fork() fails and the syscall returns -EBADF. Avoid sign-extension by casting to u32. Reported-by: Stan Johnson Closes: https://lists.debian.org/debian-68k/2024/08/msg00000.html Fixes: 6aabc1facdb2 ("m68k: Implement copy_thread_tls()") Signed-off-by: Finn Thain Reviewed-by: Geert Uytterhoeven Link: https://lore.kernel.org/3463f1e5d4e95468dc9f3368f2b78ffa7b72199b.1723335149.git.fthain@linux-m68k.org Signed-off-by: Geert Uytterhoeven Signed-off-by: Sasha Levin --- arch/m68k/kernel/process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/m68k/kernel/process.c b/arch/m68k/kernel/process.c index 1ab692b952cd6..32427aa131667 100644 --- a/arch/m68k/kernel/process.c +++ b/arch/m68k/kernel/process.c @@ -116,7 +116,7 @@ asmlinkage int m68k_clone(struct pt_regs *regs) { /* regs will be equal to current_pt_regs() */ struct kernel_clone_args args = { - .flags = regs->d1 & ~CSIGNAL, + .flags = (u32)(regs->d1) & ~CSIGNAL, .pidfd = (int __user *)regs->d3, .child_tid = (int __user *)regs->d4, .parent_tid = (int __user *)regs->d3, -- 2.43.0