From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDB351C57B1; Tue, 15 Oct 2024 12:03:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728993833; cv=none; b=ucVURBm2njZEjPN2kPsCiNN1bH81pHi/8Tnsf3lp1kl5IgY21miC5jRWvGaormo1Y4Cd+OAdVyPY5vvqFoebz0N9NOg4LcZuvhiTgvKawLnSQKB8LcPGalSeri2n5EQKeIG20JxoM/lq2nNsQR9kswVlvLmPmsk47a31Xe+dvug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728993833; c=relaxed/simple; bh=PalQjzT7K2AoDp4lUSOr/t3bw3f1frspCZ325+I/Cmw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pIoEUBdlXQvsDCaNa2KDu46CFIdM6qzYW2t7AeWZhqDV7DkVDFwH5LM2BcbGGO7EjFA0Uvs8D35hvd2fL/qOmnSNZSo7lu6507VoHBpgb0vLSZ7BYuE1QakkqTu5PGrl8lvLA+IHQW6OlqGnUQhpjMC+pHROfdeovL+Bpexx+00= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=K3DDvHMm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="K3DDvHMm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A402C4CECE; Tue, 15 Oct 2024 12:03:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728993832; bh=PalQjzT7K2AoDp4lUSOr/t3bw3f1frspCZ325+I/Cmw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=K3DDvHMm2vIELpZayuLDN4XCwRYM+Kj0Bk9JHX0QBDaEA0zm4+PnSYF29yoN+uOXP Q/2YskIGnuTg/3BbQpo2thRPQdB1FWu4uGkNSvROzQNlvnT7OqMiA1glTkSwJ8UU21 st1fupzgVC+z8XAXylyPA5NG+kuq1QVRm/06xTgw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Zheng Wang , Dikshita Agarwal , Stanimir Varbanov , Hans Verkuil Subject: [PATCH 5.15 530/691] media: venus: fix use after free bug in venus_remove due to race condition Date: Tue, 15 Oct 2024 13:27:58 +0200 Message-ID: <20241015112501.377139431@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241015112440.309539031@linuxfoundation.org> References: <20241015112440.309539031@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zheng Wang commit c5a85ed88e043474161bbfe54002c89c1cb50ee2 upstream. in venus_probe, core->work is bound with venus_sys_error_handler, which is used to handle error. The code use core->sys_err_done to make sync work. The core->work is started in venus_event_notify. If we call venus_remove, there might be an unfished work. The possible sequence is as follows: CPU0 CPU1 |venus_sys_error_handler venus_remove | hfi_destroy | venus_hfi_destroy | kfree(hdev); | |hfi_reinit |venus_hfi_queues_reinit |//use hdev Fix it by canceling the work in venus_remove. Cc: stable@vger.kernel.org Fixes: af2c3834c8ca ("[media] media: venus: adding core part and helper functions") Signed-off-by: Zheng Wang Signed-off-by: Dikshita Agarwal Signed-off-by: Stanimir Varbanov Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/media/platform/qcom/venus/core.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/media/platform/qcom/venus/core.c +++ b/drivers/media/platform/qcom/venus/core.c @@ -409,6 +409,7 @@ static int venus_remove(struct platform_ struct device *dev = core->dev; int ret; + cancel_delayed_work_sync(&core->work); ret = pm_runtime_get_sync(dev); WARN_ON(ret < 0);