From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFC261C07DD; Tue, 15 Oct 2024 12:55:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728996950; cv=none; b=rTs/NhJDs7/KNNd1obFJ8s0/DEcEHiZxNXLnQQfsuN0O3wuEoKEv31PZT1afykiobU+dz+DTLPJRhUFfdQxNan9ttDsjPbOneJcZvsvoqtzz2D7K9Ubml1gQpIqaRwieWFweQAF3bRh0D4bHPmUnAmHZWqlZwNdgh2K5h4WbKI4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728996950; c=relaxed/simple; bh=RNJhTlxW8NvWGpNTKsu0NKr75zZ2pMeCGhE3398aLEw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GEG6f33UWOs397TBPy2IrKq0txA5ILFmtGDFjS8AqQ5mJSJR7t5MsKJqSYCr0aSAYe3JKwNAMYLOBoM/UOdZ4UTpHfGirlPQ6CePzSCi3lyhN2YsUYgkean6epaOJIKj5ZuHZmGIVkIXvFQ7N8Nw6NASiQ/5XbZoY1iqki25vWs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=oEHx59If; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="oEHx59If" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8B0AC4CEC6; Tue, 15 Oct 2024 12:55:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728996950; bh=RNJhTlxW8NvWGpNTKsu0NKr75zZ2pMeCGhE3398aLEw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oEHx59IfPPNWS63bQk5uN2jEn2UOfIgNLTl28gc5hsDXIBeYaeCorjkedr4SETPBn eStYDWehix8p5i/mlZ4SOvSe3+shWBRPxbD7eMxnQnqt/OSCPko6jV8JIQWiHT/nmd sf9IitQPqAgANnMI0jdc4k0l3Lgra35/5KAFc2vs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Hagar Hemdan , Bartosz Golaszewski , Hugo SIMELIERE Subject: [PATCH 5.10 047/518] gpio: prevent potential speculation leaks in gpio_device_get_desc() Date: Tue, 15 Oct 2024 14:39:11 +0200 Message-ID: <20241015123918.826484633@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241015123916.821186887@linuxfoundation.org> References: <20241015123916.821186887@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Hagar Hemdan commit d795848ecce24a75dfd46481aee066ae6fe39775 upstream. Userspace may trigger a speculative read of an address outside the gpio descriptor array. Users can do that by calling gpio_ioctl() with an offset out of range. Offset is copied from user and then used as an array index to get the gpio descriptor without sanitization in gpio_device_get_desc(). This change ensures that the offset is sanitized by using array_index_nospec() to mitigate any possibility of speculative information leaks. This bug was discovered and resolved using Coverity Static Analysis Security Testing (SAST) by Synopsys, Inc. Signed-off-by: Hagar Hemdan Link: https://lore.kernel.org/r/20240523085332.1801-1-hagarhem@amazon.com Signed-off-by: Bartosz Golaszewski Signed-off-by: Hugo SIMELIERE Signed-off-by: Greg Kroah-Hartman --- drivers/gpio/gpiolib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -4,6 +4,7 @@ #include #include #include +#include #include #include #include @@ -143,7 +144,7 @@ struct gpio_desc *gpiochip_get_desc(stru if (hwnum >= gdev->ngpio) return ERR_PTR(-EINVAL); - return &gdev->descs[hwnum]; + return &gdev->descs[array_index_nospec(hwnum, gdev->ngpio)]; } EXPORT_SYMBOL_GPL(gpiochip_get_desc);