From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E4621C07C4; Tue, 15 Oct 2024 13:01:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728997267; cv=none; b=D0QPza+DWUUk0GM+5tGDDv+RtznaXRxrqrDth3DzWC9Fz5p2zzJ77XaJc63RDefKQJjEaD1GMrVcF/K/Fb+g5hPxmQAKh06+1UByY2/SPW8KoEBLs1smeAMdy272RTgZokBdJxSuZKxc9inh+LdjX3G8FUJDMZLoe0vFIPW+vzY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728997267; c=relaxed/simple; bh=A5hD1MhkeJLq2AAwxcTIeTrqDBbM/P2m+d5NL1DHcOI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Baqf0dY2PRigQ2HxpAj6TYon33pZnaQa3nHiClseJyNWEGQ/rF1MPHXARA//8GG1IorF2nYt2uy47Y8tJhlIwrQugqN5M3UDDuLp7+QI1AhJLYnLwKSs0oqCNzJgE3LvV2oqfDAL1m6ivepqRbZmIgVNT/a0V4NMam4zv12eW+k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=T5vmmGpV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="T5vmmGpV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D151CC4CEC6; Tue, 15 Oct 2024 13:01:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728997267; bh=A5hD1MhkeJLq2AAwxcTIeTrqDBbM/P2m+d5NL1DHcOI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T5vmmGpVna7dazlGqrz2mToNM/eBuP944tqeLXpJFSQDfP/TwJDNDh8Yx9yXwMWdg 7szjFSVklIgOns5MUOy5E5spnt3Vx5/a+DjnolyyYYR9WcaxjdAxjVIFOirRfS12E2 zv2QfkVfHu3syk4FmL/I3urCkZisQKo6RY/WU6N8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ankit Agrawal , Konrad Dybcio , Daniel Lezcano , Sasha Levin Subject: [PATCH 5.10 101/518] clocksource/drivers/qcom: Add missing iounmap() on errors in msm_dt_timer_init() Date: Tue, 15 Oct 2024 14:40:05 +0200 Message-ID: <20241015123920.898175719@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241015123916.821186887@linuxfoundation.org> References: <20241015123916.821186887@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ankit Agrawal [ Upstream commit ca140a0dc0a18acd4653b56db211fec9b2339986 ] Add the missing iounmap() when clock frequency fails to get read by the of_property_read_u32() call, or if the call to msm_timer_init() fails. Fixes: 6e3321631ac2 ("ARM: msm: Add DT support to msm_timer") Signed-off-by: Ankit Agrawal Reviewed-by: Konrad Dybcio Link: https://lore.kernel.org/r/20240713095713.GA430091@bnew-VirtualBox Signed-off-by: Daniel Lezcano Signed-off-by: Sasha Levin --- drivers/clocksource/timer-qcom.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/clocksource/timer-qcom.c b/drivers/clocksource/timer-qcom.c index b4afe3a675835..eac4c95c6127f 100644 --- a/drivers/clocksource/timer-qcom.c +++ b/drivers/clocksource/timer-qcom.c @@ -233,6 +233,7 @@ static int __init msm_dt_timer_init(struct device_node *np) } if (of_property_read_u32(np, "clock-frequency", &freq)) { + iounmap(cpu0_base); pr_err("Unknown frequency\n"); return -EINVAL; } @@ -243,7 +244,11 @@ static int __init msm_dt_timer_init(struct device_node *np) freq /= 4; writel_relaxed(DGT_CLK_CTL_DIV_4, source_base + DGT_CLK_CTL); - return msm_timer_init(freq, 32, irq, !!percpu_offset); + ret = msm_timer_init(freq, 32, irq, !!percpu_offset); + if (ret) + iounmap(cpu0_base); + + return ret; } TIMER_OF_DECLARE(kpss_timer, "qcom,kpss-timer", msm_dt_timer_init); TIMER_OF_DECLARE(scss_timer, "qcom,scss-timer", msm_dt_timer_init); -- 2.43.0