From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EABA71C07C4; Tue, 15 Oct 2024 13:01:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728997271; cv=none; b=XRRs+Vsw/4U7GX/65PmBjD5DC7lEgOjWeL2cZ+YcB3N8CjXfPmr1C+zsuct3oey5Pgff/wBkC2vkylKnpXVG1rngE154ggNuyoPq4mvEp8wgX07ozbKJtraLnTXzN6Uxx3Jva0OWLG1eWQ59ypk38SZulULSrAwCQSBZkh91PbE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728997271; c=relaxed/simple; bh=1SbLv/9JUsAWUVvusj16drT8DI7/C/mOSkFLmuaFdRI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ahgvITaG6ZSk8PTlNbw5gujt9QRFZRVQJ2KGl1q8lSZq2wBTZdag/dGoS3tRS1EPRV1E+vbD5n2wD1M+momMVSXFTgWiIvkUoqKTovWIkCnB+7vnZ7ocUDPTxJTiddjP+r5tsNPzEoUcHPihdxP9MeNtbyYVuohHrPgxmH9dPVA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=kKQCqw3l; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="kKQCqw3l" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 536F6C4CEC6; Tue, 15 Oct 2024 13:01:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728997270; bh=1SbLv/9JUsAWUVvusj16drT8DI7/C/mOSkFLmuaFdRI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kKQCqw3l6HYsyb6DD5hayTWjkXewcO/hbCFor3Wa7gf1LLAHWPHsdyIVkkHA9poOB y1V+ay7HhbS5ibuBVVJDNt+qBOwYN9Nf++jJrMf8dyBkFvd0lPfM0RRysAKPXW4Nc/ fJjyBo+iRqOiHLP8jw6vPpbeKXVUbUsLZRxCdIqA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Stan Johnson , Finn Thain , Geert Uytterhoeven , Sasha Levin Subject: [PATCH 5.10 102/518] m68k: Fix kernel_clone_args.flags in m68k_clone() Date: Tue, 15 Oct 2024 14:40:06 +0200 Message-ID: <20241015123920.938733539@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241015123916.821186887@linuxfoundation.org> References: <20241015123916.821186887@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Finn Thain [ Upstream commit 09b3d870faa7bc3e96c0978ab3cf4e96e4b15571 ] Stan Johnson recently reported a failure from the 'dump' command: DUMP: Date of this level 0 dump: Fri Aug 9 23:37:15 2024 DUMP: Dumping /dev/sda (an unlisted file system) to /dev/null DUMP: Label: none DUMP: Writing 10 Kilobyte records DUMP: mapping (Pass I) [regular files] DUMP: mapping (Pass II) [directories] DUMP: estimated 3595695 blocks. DUMP: Context save fork fails in parent 671 The dump program uses the clone syscall with the CLONE_IO flag, that is, flags == 0x80000000. When that value is promoted from long int to u64 by m68k_clone(), it undergoes sign-extension. The new value includes CLONE_INTO_CGROUP so the validation in cgroup_css_set_fork() fails and the syscall returns -EBADF. Avoid sign-extension by casting to u32. Reported-by: Stan Johnson Closes: https://lists.debian.org/debian-68k/2024/08/msg00000.html Fixes: 6aabc1facdb2 ("m68k: Implement copy_thread_tls()") Signed-off-by: Finn Thain Reviewed-by: Geert Uytterhoeven Link: https://lore.kernel.org/3463f1e5d4e95468dc9f3368f2b78ffa7b72199b.1723335149.git.fthain@linux-m68k.org Signed-off-by: Geert Uytterhoeven Signed-off-by: Sasha Levin --- arch/m68k/kernel/process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/m68k/kernel/process.c b/arch/m68k/kernel/process.c index da83cc83e7912..8c2656371a879 100644 --- a/arch/m68k/kernel/process.c +++ b/arch/m68k/kernel/process.c @@ -116,7 +116,7 @@ asmlinkage int m68k_clone(struct pt_regs *regs) { /* regs will be equal to current_pt_regs() */ struct kernel_clone_args args = { - .flags = regs->d1 & ~CSIGNAL, + .flags = (u32)(regs->d1) & ~CSIGNAL, .pidfd = (int __user *)regs->d3, .child_tid = (int __user *)regs->d4, .parent_tid = (int __user *)regs->d3, -- 2.43.0