From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E901E1AF0AD; Tue, 15 Oct 2024 13:02:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728997352; cv=none; b=WQ+FWItNqBnDB/+Au+B8rCaNbGcyYfXQwO//MMFW8qcGsWLI2kN6t+dPljjJNLruds/iFKaRRJCj1OM7vaVc7DYRa0c9nPZeuivpCglvteWJb8y2YmJDRuex4YTg3KR7H1SpUnl/vGs1WccCYQrwzMBUni9VYHEAWPKDhPIqUjM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728997352; c=relaxed/simple; bh=k4FGgg7RAgrs6tKPL4+2EzDQfqkRoEV8g1JvtV3mhUk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AyRIKyVyver07Kv3hT5VIfEtb9WQ5G9nOdPcDdvliZVYvheF8zcXuWYvWxccw7clTgS8Pn7OJRytVFKJ2Ou0rBG7HWfKp1lsnsiL0oDQC4XFDSLhsdR5DH0zkv3bbMR2W7JJ8ytCz4yGy1qzXeCEREIBxSf+2NOq0XbcCsnOsw8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=UdFKxOGc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="UdFKxOGc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64A6BC4CECE; Tue, 15 Oct 2024 13:02:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728997351; bh=k4FGgg7RAgrs6tKPL4+2EzDQfqkRoEV8g1JvtV3mhUk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UdFKxOGcr9KX2UHhXOuqb8zWeJFsXkrP9aqXW+MGVCcU3nSeLbVw2RqQUglzUcCyB 9sSDERr2z2AAtm/0zz4fIj02ku6Pe48jWyF6XwgHnJb/iqT5+LCEm3LSErvf/UnVtN kAOGX3aHutCpiP0wLKO4snzYSQNXb0UUR1o2913s= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Sasha Levin Subject: [PATCH 5.10 157/518] bpf: Fix bpf_strtol and bpf_strtoul helpers for 32bit Date: Tue, 15 Oct 2024 14:41:01 +0200 Message-ID: <20241015123923.063106849@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241015123916.821186887@linuxfoundation.org> References: <20241015123916.821186887@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Daniel Borkmann [ Upstream commit cfe69c50b05510b24e26ccb427c7cc70beafd6c1 ] The bpf_strtol() and bpf_strtoul() helpers are currently broken on 32bit: The argument type ARG_PTR_TO_LONG is BPF-side "long", not kernel-side "long" and therefore always considered fixed 64bit no matter if 64 or 32bit underlying architecture. This contract breaks in case of the two mentioned helpers since their BPF_CALL definition for the helpers was added with {unsigned,}long *res. Meaning, the transition from BPF-side "long" (BPF program) to kernel-side "long" (BPF helper) breaks here. Both helpers call __bpf_strtoll() with "long long" correctly, but later assigning the result into 32-bit "*(long *)" on 32bit architectures. From a BPF program point of view, this means upper bits will be seen as uninitialised. Therefore, fix both BPF_CALL signatures to {s,u}64 types to fix this situation. Now, changing also uapi/bpf.h helper documentation which generates bpf_helper_defs.h for BPF programs is tricky: Changing signatures there to __{s,u}64 would trigger compiler warnings (incompatible pointer types passing 'long *' to parameter of type '__s64 *' (aka 'long long *')) for existing BPF programs. Leaving the signatures as-is would be fine as from BPF program point of view it is still BPF-side "long" and thus equivalent to __{s,u}64 on 64 or 32bit underlying architectures. Note that bpf_strtol() and bpf_strtoul() are the only helpers with this issue. Fixes: d7a4cb9b6705 ("bpf: Introduce bpf_strtol and bpf_strtoul helpers") Reported-by: Alexei Starovoitov Signed-off-by: Daniel Borkmann Acked-by: Andrii Nakryiko Link: https://lore.kernel.org/bpf/481fcec8-c12c-9abb-8ecb-76c71c009959@iogearbox.net Link: https://lore.kernel.org/r/20240913191754.13290-1-daniel@iogearbox.net Signed-off-by: Alexei Starovoitov Signed-off-by: Sasha Levin --- kernel/bpf/helpers.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c index 084ac7e429199..31e3a54821564 100644 --- a/kernel/bpf/helpers.c +++ b/kernel/bpf/helpers.c @@ -497,7 +497,7 @@ static int __bpf_strtoll(const char *buf, size_t buf_len, u64 flags, } BPF_CALL_4(bpf_strtol, const char *, buf, size_t, buf_len, u64, flags, - long *, res) + s64 *, res) { long long _res; int err; @@ -522,7 +522,7 @@ const struct bpf_func_proto bpf_strtol_proto = { }; BPF_CALL_4(bpf_strtoul, const char *, buf, size_t, buf_len, u64, flags, - unsigned long *, res) + u64 *, res) { unsigned long long _res; bool is_negative; -- 2.43.0