From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7733D1C07DB; Tue, 15 Oct 2024 13:04:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728997498; cv=none; b=KEHhE9n1g3lPGsMEIMm5kqdfRhAsW9j+Fcfg+k7inyQJqV/JO7mkI2LFrFOM2wAvpaLWqtmgYOVoTOeW+5ix4ya4OQ+GJuYNjOYoMMfiDo4vTlrIswuYGoP5/V1bfOua3DhtefwWQi85EaJS5ef+P+T3dt/i6KoTm46fvL+FH88= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728997498; c=relaxed/simple; bh=Jn9a2/lBj92IwzrsExTJ9xHXk69ndwRuttUahoiK7pg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=o2GUK/q0ZF81P4Jb4LVowmnYYe9BtQmu28nhaDNn8aOythD35coVYxa2ekVUf2WGTbk9tsVpf0dCIm7tAvBnYAUbMhWj/7Pk8Vc4Eqdr8GScg9tnzQ74eE7D56JFqBHGbXT1d+OiOYwU/PcpyAyknYV7/I42Qi9LzTV2MdOqN5Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=naYgGwyI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="naYgGwyI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D45CCC4CEC6; Tue, 15 Oct 2024 13:04:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728997498; bh=Jn9a2/lBj92IwzrsExTJ9xHXk69ndwRuttUahoiK7pg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=naYgGwyIRRP1AgdapHE3D9v2q5K9wDYK+T7xWEFHdlQhAwSlfFU9+CXjZIFITV/gZ hczMbGRGEXgzhCFIHqwL9nHtxjfU5UFTZBNVmbfpWYy86tdVdgAY10rVjOLTgINhOl 2mwPqRby0v50v754gbXyT2Zu1t5sxZNP3cxq1eb0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, David Lechner , Stephen Boyd , Sasha Levin Subject: [PATCH 5.10 169/518] clk: ti: dra7-atl: Fix leak of of_nodes Date: Tue, 15 Oct 2024 14:41:13 +0200 Message-ID: <20241015123923.517018153@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241015123916.821186887@linuxfoundation.org> References: <20241015123916.821186887@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: David Lechner [ Upstream commit 9d6e9f10e2e031fb7bfb3030a7d1afc561a28fea ] This fix leaking the of_node references in of_dra7_atl_clk_probe(). The docs for of_parse_phandle_with_args() say that the caller must call of_node_put() on the returned node. This adds the missing of_node_put() to fix the leak. Fixes: 9ac33b0ce81f ("CLK: TI: Driver for DRA7 ATL (Audio Tracking Logic)") Signed-off-by: David Lechner Link: https://lore.kernel.org/r/20240826-clk-fix-leak-v1-1-f55418a13aa6@baylibre.com Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/ti/clk-dra7-atl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/ti/clk-dra7-atl.c b/drivers/clk/ti/clk-dra7-atl.c index 62508e74a47a7..fc266c0ab6293 100644 --- a/drivers/clk/ti/clk-dra7-atl.c +++ b/drivers/clk/ti/clk-dra7-atl.c @@ -258,6 +258,7 @@ static int of_dra7_atl_clk_probe(struct platform_device *pdev) } clk = of_clk_get_from_provider(&clkspec); + of_node_put(clkspec.np); if (IS_ERR(clk)) { pr_err("%s: failed to get atl clock %d from provider\n", __func__, i); -- 2.43.0