From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 378301AF0B4; Tue, 15 Oct 2024 13:03:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728997432; cv=none; b=J+fn/fxBLA2s3bYv1n9a7YjCRTtUxy326UQluXP6iKz/qNPKI4OSqqGnhrIotMxrnHRHee6EtmsrYgI6cPQTgvjQESQ9LixO3cEpB+Nz1Cl+oePpbjnpo71NZzcfLb2FpsaibQAwK76L6UPYCPggB3Z7xvjwcZq2G2gzWyNe9h4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728997432; c=relaxed/simple; bh=3GX6JZGyZGB2HpYHaIcX5BECTUIqDabfnKBKlkgAJ2k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WCsc2hnlVF8DCVrrF+5eULApR8rFDWVP95KTf6Lh+O78oGZuV68vekYJIuUDaiC1A35BRr2EtclktF5mThPRi2F52Mo4PwQZQupVNXt3vnFQ2ysGOHY7Daln2UUvuQolgcs/w7QFnCZDzc2X8zWxdJyR4rqNH3R1aWePg9mzxsI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=QbBhvv8c; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="QbBhvv8c" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E844C4CEC6; Tue, 15 Oct 2024 13:03:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728997432; bh=3GX6JZGyZGB2HpYHaIcX5BECTUIqDabfnKBKlkgAJ2k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QbBhvv8cf0Gs5udxIDakoHWcOrHJ50tRRbXjNPc4wWkBY/MTLernqvNVXayKGZq3W LVf8Hez0sl2osAg3vMVGaXpZut3+XrEK6yx9fenAemYl6TiNmqR9WkN1jLod3SruQl OUIwugXqp5U+BiURJKnh82w/AGsSHypvhRHN7ui8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Mikhail Lobanov , Leon Romanovsky , Sasha Levin Subject: [PATCH 5.10 181/518] RDMA/cxgb4: Added NULL check for lookup_atid Date: Tue, 15 Oct 2024 14:41:25 +0200 Message-ID: <20241015123923.976713057@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241015123916.821186887@linuxfoundation.org> References: <20241015123916.821186887@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mikhail Lobanov [ Upstream commit e766e6a92410ca269161de059fff0843b8ddd65f ] The lookup_atid() function can return NULL if the ATID is invalid or does not exist in the identifier table, which could lead to dereferencing a null pointer without a check in the `act_establish()` and `act_open_rpl()` functions. Add a NULL check to prevent null pointer dereferencing. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: cfdda9d76436 ("RDMA/cxgb4: Add driver for Chelsio T4 RNIC") Signed-off-by: Mikhail Lobanov Link: https://patch.msgid.link/20240912145844.77516-1-m.lobanov@rosalinux.ru Signed-off-by: Leon Romanovsky Signed-off-by: Sasha Levin --- drivers/infiniband/hw/cxgb4/cm.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c index 8c54b1be04424..95300b2e1ffe9 100644 --- a/drivers/infiniband/hw/cxgb4/cm.c +++ b/drivers/infiniband/hw/cxgb4/cm.c @@ -1222,6 +1222,8 @@ static int act_establish(struct c4iw_dev *dev, struct sk_buff *skb) int ret; ep = lookup_atid(t, atid); + if (!ep) + return -EINVAL; pr_debug("ep %p tid %u snd_isn %u rcv_isn %u\n", ep, tid, be32_to_cpu(req->snd_isn), be32_to_cpu(req->rcv_isn)); @@ -2279,6 +2281,9 @@ static int act_open_rpl(struct c4iw_dev *dev, struct sk_buff *skb) int ret = 0; ep = lookup_atid(t, atid); + if (!ep) + return -EINVAL; + la = (struct sockaddr_in *)&ep->com.local_addr; ra = (struct sockaddr_in *)&ep->com.remote_addr; la6 = (struct sockaddr_in6 *)&ep->com.local_addr; -- 2.43.0