From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7B2E1C07DF; Tue, 15 Oct 2024 13:12:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728997977; cv=none; b=k5umUc5Q3/W9GUhnLblvby4WvE4fQAo4G6KDX01TlyLf6OA8eqTUSV9nQms8O4oAl54rAXtCrUA10WDaMEqZ5hCdJWVKDElVX9O+axSz4tUisu/cU7gqxeXqwGWMk/cd4GyAnzvejJ/QhwLqrMIZlFXqVHfRnOch9rdmunsy8Ac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728997977; c=relaxed/simple; bh=WAtzophLqe3yQ4EvHb/egoQUN3loa3rmaaHn2sVkxds=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HsDgDzITrHXZ58v4aYEcBK7CN9IfQi1RF9lxSoywaBtHl0DdBfFO2P9wVF8ProaPEik3bxIdURo3EphkoybY+MmBrh8F8m9bkHRuIOS3jTOsmVEQI2uqHI4puX/c45u5fs1NhA9rp8OXVKN4g2X/Hpz2oiJMwrVVRXn9ormr8vI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=rdoh/pM7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="rdoh/pM7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C4B7C4CEC6; Tue, 15 Oct 2024 13:12:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728997977; bh=WAtzophLqe3yQ4EvHb/egoQUN3loa3rmaaHn2sVkxds=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rdoh/pM7UwPRCpppHMMY7caeD0uGiOfgWL5IMErLj1Vusjib/mVyHJrza7QlrCEd3 53uxltTAs+yEL816N/jHfVeeZtvWaWU4+IgMjGJAbBjxUqRCCyLo2LwdcbUzVKSybw M4DD7VvjDp5wSylBTEpXzeGdcnnWWWGBCqe/OWjk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Edward Adam Davis , Dave Kleikamp , Sasha Levin , syzbot+dca05492eff41f604890@syzkaller.appspotmail.com Subject: [PATCH 5.10 336/518] jfs: check if leafidx greater than num leaves per dmap tree Date: Tue, 15 Oct 2024 14:44:00 +0200 Message-ID: <20241015123929.942166467@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241015123916.821186887@linuxfoundation.org> References: <20241015123916.821186887@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Edward Adam Davis [ Upstream commit d64ff0d2306713ff084d4b09f84ed1a8c75ecc32 ] syzbot report a out of bounds in dbSplit, it because dmt_leafidx greater than num leaves per dmap tree, add a checking for dmt_leafidx in dbFindLeaf. Shaggy: Modified sanity check to apply to control pages as well as leaf pages. Reported-and-tested-by: syzbot+dca05492eff41f604890@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=dca05492eff41f604890 Signed-off-by: Edward Adam Davis Signed-off-by: Dave Kleikamp Signed-off-by: Sasha Levin --- fs/jfs/jfs_dmap.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/jfs/jfs_dmap.c b/fs/jfs/jfs_dmap.c index 750853367d4ff..8efd93992946b 100644 --- a/fs/jfs/jfs_dmap.c +++ b/fs/jfs/jfs_dmap.c @@ -3006,9 +3006,10 @@ static void dbAdjTree(dmtree_t *tp, int leafno, int newval, bool is_ctl) static int dbFindLeaf(dmtree_t *tp, int l2nb, int *leafidx, bool is_ctl) { int ti, n = 0, k, x = 0; - int max_size; + int max_size, max_idx; max_size = is_ctl ? CTLTREESIZE : TREESIZE; + max_idx = is_ctl ? LPERCTL : LPERDMAP; /* first check the root of the tree to see if there is * sufficient free space. @@ -3040,6 +3041,8 @@ static int dbFindLeaf(dmtree_t *tp, int l2nb, int *leafidx, bool is_ctl) */ assert(n < 4); } + if (le32_to_cpu(tp->dmt_leafidx) >= max_idx) + return -ENOSPC; /* set the return to the leftmost leaf describing sufficient * free space. -- 2.43.0