From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5088A1C4A05; Tue, 15 Oct 2024 13:18:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728998301; cv=none; b=j78SWQfaZ8x7jgQBHffH4xi11ZL8SjJIZqhmM8pSNqCGycgJNdMeAMkFnRPyBWqa1CW+BL6A7kS6SzD+C4QkvTtoMH3r2sW0hoElF2RaU+XI3FSY1UvmEvtoBk+4tqrpwwBFhdQLpdS0WFe5ukG73tMj9L3o8/pqUt6JfV/hNPQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728998301; c=relaxed/simple; bh=zrIw9Q+t/lwAVe5G6adaeEYDXbMcJLk6HPWzpxGtWHA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oX+jfk7hiVKR3NvFz68wpnIU5cFeovHZcrVQGkIiBoE5m6DivBbPpB74V8eDEi9nCKnYlE4RzbxvxNuYvxun5Fcx3mx5jDQsc8k/ewDM6gIF6xb+dht1veFFGSs3P47LTg/4lH2r2gePaPAi04SdPTQ2/9MetbQx9c3oZNAFJfM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=N0K2MOZl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="N0K2MOZl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79364C4CECE; Tue, 15 Oct 2024 13:18:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728998300; bh=zrIw9Q+t/lwAVe5G6adaeEYDXbMcJLk6HPWzpxGtWHA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=N0K2MOZlGL3NQLSOMYLi5IZa2qRrZTKBtiAAuiykkG92EBka9k3HdWhm93HP6Avxb KGklhF9fPPezp6bhCRLLCyco7rX4Qtu3xZUWfJo9VWmPl3x0VUtxnRJRKbRGz57Q1F 9R57ZKPwtHW4JmFP7yYa+UgBcId+cSQ5XCPsUi3s= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Choong Yong Liang , KhaiWenTan , Simon Horman , Paolo Abeni Subject: [PATCH 5.10 407/518] net: stmmac: Fix zero-division error when disabling tc cbs Date: Tue, 15 Oct 2024 14:45:11 +0200 Message-ID: <20241015123932.692151027@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241015123916.821186887@linuxfoundation.org> References: <20241015123916.821186887@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: KhaiWenTan commit 675faf5a14c14a2be0b870db30a70764df81e2df upstream. The commit b8c43360f6e4 ("net: stmmac: No need to calculate speed divider when offload is disabled") allows the "port_transmit_rate_kbps" to be set to a value of 0, which is then passed to the "div_s64" function when tc-cbs is disabled. This leads to a zero-division error. When tc-cbs is disabled, the idleslope, sendslope, and credit values the credit values are not required to be configured. Therefore, adding a return statement after setting the txQ mode to DCB when tc-cbs is disabled would prevent a zero-division error. Fixes: b8c43360f6e4 ("net: stmmac: No need to calculate speed divider when offload is disabled") Cc: Co-developed-by: Choong Yong Liang Signed-off-by: Choong Yong Liang Signed-off-by: KhaiWenTan Reviewed-by: Simon Horman Link: https://patch.msgid.link/20240918061422.1589662-1-khai.wen.tan@linux.intel.com Signed-off-by: Paolo Abeni Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c @@ -363,6 +363,7 @@ static int tc_setup_cbs(struct stmmac_pr return ret; priv->plat->tx_queues_cfg[queue].mode_to_use = MTL_QUEUE_DCB; + return 0; } /* Final adjustments for HW */