From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BB2D1AF0CE; Tue, 15 Oct 2024 13:20:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728998415; cv=none; b=pPT3b5TIEcQuGqcW0Odo2CihvjAi4V0ifiPRhB/xTk6CzulKuDcoRZQ8LSbjphMnh3tjaTL3BUV/94P6kCq+qkBWAAyhYIgTAZmAxyuctLxoW/aXMtQQQ2WxiPTr7ytj5S0ZFh89Xz4w1Jac7sL73nKW/WfPRBAl9mh68KPxRoI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728998415; c=relaxed/simple; bh=GWR45q1zeh9J5xViJYo0wvPNj0sMGbdTR5WQt6Q9fls=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=G/9mm21MuBzjp5oP+vyXA5hNqaK/Vk9K6LlOc02RgTdWNsJfb67N9UBK2IeqlQmbb4Dy0wm8tvEIix2giMHtv7tm+Wjt8WSkkTFjGlVAdPs3Xo5XPzt25KV8u5omeIbu3Ud6ITVqPsyPQmSCZ2KcVvfVlnjDpxS5aS9QD0bBOxU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ektwNJ2J; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ektwNJ2J" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27BB8C4CEC6; Tue, 15 Oct 2024 13:20:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728998414; bh=GWR45q1zeh9J5xViJYo0wvPNj0sMGbdTR5WQt6Q9fls=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ektwNJ2JXcNHVUmIz2OMN/67BqDCYFSsI4YUdUc5G9YF5VjWYFnyZPVGIQM+grBqu B3WikVEBUOMATVzJsspDpt3vPO6dKJhgLzV68g5ZAP2zEZCItxVz3WtmOQqpTfyYW1 d1UYf2rcKM+RwJFk2nNnJ6UJ8fCozTQ6IFswYm/0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Alex Hung , Rodrigo Siqueira , Daniel Wheeler , Alex Deucher , Sasha Levin Subject: [PATCH 5.10 469/518] drm/amd/display: Check null pointer before dereferencing se Date: Tue, 15 Oct 2024 14:46:13 +0200 Message-ID: <20241015123935.106802642@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241015123916.821186887@linuxfoundation.org> References: <20241015123916.821186887@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Alex Hung [ Upstream commit ff599ef6970ee000fa5bc38d02fa5ff5f3fc7575 ] [WHAT & HOW] se is null checked previously in the same function, indicating it might be null; therefore, it must be checked when used again. This fixes 1 FORWARD_NULL issue reported by Coverity. Acked-by: Alex Hung Reviewed-by: Rodrigo Siqueira Signed-off-by: Alex Hung Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c index 661907e8a7dec..84fb1377ec934 100644 --- a/drivers/gpu/drm/amd/display/dc/core/dc.c +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c @@ -1258,7 +1258,7 @@ bool dc_validate_seamless_boot_timing(const struct dc *dc, if (crtc_timing->pix_clk_100hz != pix_clk_100hz) return false; - if (!se->funcs->dp_get_pixel_format) + if (!se || !se->funcs->dp_get_pixel_format) return false; if (!se->funcs->dp_get_pixel_format( -- 2.43.0