From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51DB1205E26; Tue, 15 Oct 2024 13:21:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728998492; cv=none; b=F+KU1i9NV+jBQCFZO0TrNNE7M2eOAdgW0VnYEPVvNipHT8Rr3dN/gXfZxHN5tAz99QrHK2XFoRjGz2v/B5kAQlsb1AIdAr9eeC9Fy/v7SmnqlwiA1xtYimiR8cetqnItyJyV+r0mu1GKEXcWb2L43qOboIw2x2s+OXtwvUCmpeI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728998492; c=relaxed/simple; bh=ev8Z0bCreZXgEe50io2KX4ZLjwKNatZ9aJdD3oN1vhc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T00fx6QNIW2tUioaqRS0d6JpZhY+X8jcP7ufJCNQTEuLzFOWvYdD3e/32p0ptyLA1Su6KFeLdT8cveNO9kv7iqTyJT+ORgF1AKpCz9LT2AF74wqLrcuyycw5TVUYg3Di7XVuBZG6gkrUryTMuvl68dACjY+PXNsUvHlUef0ANfs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=jrwPuTui; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="jrwPuTui" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C707C4CEC6; Tue, 15 Oct 2024 13:21:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728998492; bh=ev8Z0bCreZXgEe50io2KX4ZLjwKNatZ9aJdD3oN1vhc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jrwPuTuiRG0FKPnhVoUvzViQQJXu3pBGBVLoGo2JQjQYdcmw3l0sPmHQyrPcJFOac 5DfwqOC28RKukXH8d2pVvE52lGr9z1QoUdhu4uvco7fkXgBDxg9Q4fL8ECJWrQr3X4 ARyZu4ys1qg7vYWEoylWm98cUGYvjrUI44v3bG+M= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Marcelo Ricardo Leitner , Xin Long , "David S. Miller" , Sasha Levin Subject: [PATCH 5.10 492/518] sctp: ensure sk_state is set to CLOSED if hashing fails in sctp_listen_start Date: Tue, 15 Oct 2024 14:46:36 +0200 Message-ID: <20241015123935.988330761@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241015123916.821186887@linuxfoundation.org> References: <20241015123916.821186887@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Xin Long [ Upstream commit 4d5c70e6155d5eae198bade4afeab3c1b15073b6 ] If hashing fails in sctp_listen_start(), the socket remains in the LISTENING state, even though it was not added to the hash table. This can lead to a scenario where a socket appears to be listening without actually being accessible. This patch ensures that if the hashing operation fails, the sk_state is set back to CLOSED before returning an error. Note that there is no need to undo the autobind operation if hashing fails, as the bind port can still be used for next listen() call on the same socket. Fixes: 76c6d988aeb3 ("sctp: add sock_reuseport for the sock in __sctp_hash_endpoint") Reported-by: Marcelo Ricardo Leitner Signed-off-by: Xin Long Acked-by: Marcelo Ricardo Leitner Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/sctp/socket.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/net/sctp/socket.c b/net/sctp/socket.c index c1b713a260602..f529574aa0683 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -8273,6 +8273,7 @@ static int sctp_listen_start(struct sock *sk, int backlog) struct sctp_endpoint *ep = sp->ep; struct crypto_shash *tfm = NULL; char alg[32]; + int err; /* Allocate HMAC for generating cookie. */ if (!sp->hmac && sp->sctp_hmac_alg) { @@ -8300,18 +8301,25 @@ static int sctp_listen_start(struct sock *sk, int backlog) inet_sk_set_state(sk, SCTP_SS_LISTENING); if (!ep->base.bind_addr.port) { if (sctp_autobind(sk)) { - inet_sk_set_state(sk, SCTP_SS_CLOSED); - return -EAGAIN; + err = -EAGAIN; + goto err; } } else { if (sctp_get_port(sk, inet_sk(sk)->inet_num)) { - inet_sk_set_state(sk, SCTP_SS_CLOSED); - return -EADDRINUSE; + err = -EADDRINUSE; + goto err; } } WRITE_ONCE(sk->sk_max_ack_backlog, backlog); - return sctp_hash_endpoint(ep); + err = sctp_hash_endpoint(ep); + if (err) + goto err; + + return 0; +err: + inet_sk_set_state(sk, SCTP_SS_CLOSED); + return err; } /* -- 2.43.0