From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10BD515B10D; Mon, 28 Oct 2024 06:36:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730097414; cv=none; b=nZzSb5h7AQ+3PyPxEuwiHeTkeStLMJCIEGLDM9ggUvXlYUkNkueutjtrbSAePUd9Z6P8g8L3UJsUGosixAG1NANPL6hgxycSRmuJ92YJgLgs8jZfvYmq/36XHXF1CXKKFxE/50e8FltiSfWdbg71avWvU9Y5v0QHCaK2GLlAIcI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730097414; c=relaxed/simple; bh=vvUX10xGAw3G6tW6Ag4+vJKQAWAj2BsK6Yp/L3uPNjY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jm1A/0joF8chwWZwF4aJ/X8ivqimjZy2IHAjSDgwK3aeaEZkJWnweF4c9OUK5RXcOjuK2UugeY+P6wJ4+UBdw/yiA7TSqAG3rqUjlhzPYmPzUjH32RsrFvDkCN3knpVjywuFN7fJN245SFq3IWfNWDAbIzyYwvgOxD5udCjkzG4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=SYWRS1K/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="SYWRS1K/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4F21C4CEC3; Mon, 28 Oct 2024 06:36:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1730097413; bh=vvUX10xGAw3G6tW6Ag4+vJKQAWAj2BsK6Yp/L3uPNjY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SYWRS1K/Puq+GDkQ7F+tS+E4Q4MtB4FR6PElul/u/Ef95WE5EDmRsq2F+GEbAYmhP o4M9TtSUKq4bpbCAu7IsB9bFZfoAcfWMogkbD8jcfdgoaN0nHuNtthe8MXp7oK8apv 396bwlxGDvdh4WkEGZ8SnrdrmfUqiTfHGae/OGS4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Atlas Yu , Heiner Kallweit , Simon Horman , Paolo Abeni , Sasha Levin Subject: [PATCH 6.1 103/137] r8169: avoid unsolicited interrupts Date: Mon, 28 Oct 2024 07:25:40 +0100 Message-ID: <20241028062301.601950580@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241028062258.708872330@linuxfoundation.org> References: <20241028062258.708872330@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Heiner Kallweit [ Upstream commit 10ce0db787004875f4dba068ea952207d1d8abeb ] It was reported that after resume from suspend a PCI error is logged and connectivity is broken. Error message is: PCI error (cmd = 0x0407, status_errs = 0x0000) The message seems to be a red herring as none of the error bits is set, and the PCI command register value also is normal. Exception handling for a PCI error includes a chip reset what apparently brakes connectivity here. The interrupt status bit triggering the PCI error handling isn't actually used on PCIe chip versions, so it's not clear why this bit is set by the chip. Fix this by ignoring this bit on PCIe chip versions. Fixes: 0e4851502f84 ("r8169: merge with version 8.001.00 of Realtek's r8168 driver") Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219388 Tested-by: Atlas Yu Signed-off-by: Heiner Kallweit Reviewed-by: Simon Horman Link: https://patch.msgid.link/78e2f535-438f-4212-ad94-a77637ac6c9c@gmail.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/ethernet/realtek/r8169_main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index 8b35e14fba3a8..a74e33bf0302e 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -4617,7 +4617,9 @@ static irqreturn_t rtl8169_interrupt(int irq, void *dev_instance) if ((status & 0xffff) == 0xffff || !(status & tp->irq_mask)) return IRQ_NONE; - if (unlikely(status & SYSErr)) { + /* At least RTL8168fp may unexpectedly set the SYSErr bit */ + if (unlikely(status & SYSErr && + tp->mac_version <= RTL_GIGA_MAC_VER_06)) { rtl8169_pcierr_interrupt(tp->dev); goto out; } -- 2.43.0