From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B96C0A47; Mon, 28 Oct 2024 06:45:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730097913; cv=none; b=k/t6h9QszYV23QQr4JXTTwz8BiKgKubTkXkJgGZiYSuOYpjE1LFtv110TqhN6iWp8z23YfbiVAyLsolaf1fwltATbwVCKOrnnigDs3ac9jYJnEYddVNgRLzoXHQRgAr8/WqYNcS3ym/4j3RuIQx8sjUpCMXagPWj+xZJT2/8SX8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730097913; c=relaxed/simple; bh=IpoNLsA8EB0TX4ViwuT2mPnxXVS130rvOCbcJ2cRcSk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=g22raIWCaGicfGjLRz/dKJufWfiAlon2118wU+fkCVFEKORs/Yc5BQVDvGASHDPKDsh8ixRPDb80zZfd1/hAWaAgz0Yl8l7z5lfA+2LZ8fWY9MDNZ94+ur5T9gJzxblF87LYGX/y8ghBDpBHCfcRSqw3t1kAgR1ApicpfeEjWGI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=fRrd4PYd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="fRrd4PYd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A0CEC4CEC3; Mon, 28 Oct 2024 06:45:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1730097913; bh=IpoNLsA8EB0TX4ViwuT2mPnxXVS130rvOCbcJ2cRcSk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fRrd4PYdCgN3vMFSJHQGezMCjxGv4TGOtuf6dSYkaTN1SRxRMLCXXT/kRLS+veEUc DV4FJA52pztFYOk2uWkT4m1AbCLDwqdjPWyjjN6uqT5YnoiHcI5+sLXHTQPANNIiTl 0ZyvDbOLnlv9VeByJZ5cpFAOJ/L/hdPtCMonnefg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Linux Kernel Functional Testing , Ard Biesheuvel , Dan Carpenter , "Paul E. McKenney" , "Rafael J. Wysocki" Subject: [PATCH 6.6 203/208] ACPI: PRM: Clean up guid type in struct prm_handler_info Date: Mon, 28 Oct 2024 07:26:23 +0100 Message-ID: <20241028062311.644446509@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241028062306.649733554@linuxfoundation.org> References: <20241028062306.649733554@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dan Carpenter commit 3d1c651272cf1df8aac7d9b6d92d836d27bed50f upstream. Clang 19 prints a warning when we pass &th->guid to efi_pa_va_lookup(): drivers/acpi/prmt.c:156:29: error: passing 1-byte aligned argument to 4-byte aligned parameter 1 of 'efi_pa_va_lookup' may result in an unaligned pointer access [-Werror,-Walign-mismatch] 156 | (void *)efi_pa_va_lookup(&th->guid, handler_info->handler_address); | ^ The problem is that efi_pa_va_lookup() takes a efi_guid_t and &th->guid is a regular guid_t. The difference between the two types is the alignment. efi_guid_t is a typedef. typedef guid_t efi_guid_t __aligned(__alignof__(u32)); It's possible that this a bug in Clang 19. Even though the alignment of &th->guid is not explicitly specified, it will still end up being aligned at 4 or 8 bytes. Anyway, as Ard points out, it's cleaner to change guid to efi_guid_t type and that also makes the warning go away. Fixes: 088984c8d54c ("ACPI: PRM: Find EFI_MEMORY_RUNTIME block for PRM handler and context") Reported-by: Linux Kernel Functional Testing Suggested-by: Ard Biesheuvel Signed-off-by: Dan Carpenter Tested-by: Paul E. McKenney Acked-by: Ard Biesheuvel Link: https://patch.msgid.link/3777d71b-9e19-45f4-be4e-17bf4fa7a834@stanley.mountain [ rjw: Subject edit ] Signed-off-by: Rafael J. Wysocki Signed-off-by: Greg Kroah-Hartman --- drivers/acpi/prmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/acpi/prmt.c +++ b/drivers/acpi/prmt.c @@ -52,7 +52,7 @@ struct prm_context_buffer { static LIST_HEAD(prm_module_list); struct prm_handler_info { - guid_t guid; + efi_guid_t guid; efi_status_t (__efiapi *handler_addr)(u64, void *); u64 static_data_buffer_addr; u64 acpi_param_buffer_addr;