From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CCC81F131D; Wed, 6 Nov 2024 12:37:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730896622; cv=none; b=R5VH/myYfN8SOMB95XT5EEyMclW9gGKN9ANIneeSh4HLSUjtY9KHvOCEUCBSaby2/zmnHxBvYmtv6iWf32t3fH7MsELnAIM86tVSpGIo/JNRbrhJdLjkoPcNv5t8dlT9cQ49C3HuMfKKLU3tFL2ZJukxZ2rjOAMCM/xjLdV83Wc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730896622; c=relaxed/simple; bh=miFVAUOC5l0hzyAfYy5eiZsCoV+4TLHjOPVX0Oy9Gu0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=M+iIy/k3IsKV3X1P+WjEbQ6LlOdX5L7VT15jlUs51D27qc1WPojMyox+iVQOv/j/uiUkr0IZ90ERezoIWZz978/UalQAwsujinVnfREi/36IFYF1QAGcOMGzWTF9snszEIPeiy0iC9j9h9cAUS62ugVSPN176snyVd1rTRIyvdI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=bK2FZaRj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="bK2FZaRj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC08EC4CEDB; Wed, 6 Nov 2024 12:37:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1730896622; bh=miFVAUOC5l0hzyAfYy5eiZsCoV+4TLHjOPVX0Oy9Gu0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bK2FZaRjcaDlmjSxv58WeJgbdH0D98fIF8kIaPLkgyxoUN4HBnfLl/gsrbPRPxQaJ iU4CJklBundhLO01pPkucb2BpcXKDre25qrmUVBo8crzmOpB90Ag1XPQe8OBvytJN/ cP4c7MFDUy6EMfO1nfdQiw6VnGaa7z+tQqzKfeg8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ye Bin , Luiz Augusto von Dentz , Sasha Levin Subject: [PATCH 5.10 018/110] Bluetooth: bnep: fix wild-memory-access in proto_unregister Date: Wed, 6 Nov 2024 13:03:44 +0100 Message-ID: <20241106120303.661650274@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241106120303.135636370@linuxfoundation.org> References: <20241106120303.135636370@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ye Bin [ Upstream commit 64a90991ba8d4e32e3173ddd83d0b24167a5668c ] There's issue as follows: KASAN: maybe wild-memory-access in range [0xdead...108-0xdead...10f] CPU: 3 UID: 0 PID: 2805 Comm: rmmod Tainted: G W RIP: 0010:proto_unregister+0xee/0x400 Call Trace: __do_sys_delete_module+0x318/0x580 do_syscall_64+0xc1/0x1d0 entry_SYSCALL_64_after_hwframe+0x77/0x7f As bnep_init() ignore bnep_sock_init()'s return value, and bnep_sock_init() will cleanup all resource. Then when remove bnep module will call bnep_sock_cleanup() to cleanup sock's resource. To solve above issue just return bnep_sock_init()'s return value in bnep_exit(). Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Ye Bin Signed-off-by: Luiz Augusto von Dentz Signed-off-by: Sasha Levin --- net/bluetooth/bnep/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/bluetooth/bnep/core.c b/net/bluetooth/bnep/core.c index f749904272961..0eaa47ae6e993 100644 --- a/net/bluetooth/bnep/core.c +++ b/net/bluetooth/bnep/core.c @@ -745,8 +745,7 @@ static int __init bnep_init(void) if (flt[0]) BT_INFO("BNEP filters: %s", flt); - bnep_sock_init(); - return 0; + return bnep_sock_init(); } static void __exit bnep_exit(void) -- 2.43.0