From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8086A1F667E; Wed, 6 Nov 2024 12:41:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730896892; cv=none; b=YWazmjPUNOhpxVPvKpU42o3OT6bA+kkweISDdXWwhvZy/Nqdwzdq59bywFPC4pE56asyZhncR7U5B20/p0dPBDeD9pKtm6LgdbMhb/aTuRvDsOusc1SaZU8OAhzegPoHCSoE2IkK6FlqHAYK0YKSp1KdyPxzMSSlJtKWkb7fugU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730896892; c=relaxed/simple; bh=gfLlThbJNrGIMTjYZ7GB32DMkWjX3+uaegcCrCY/GWE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AQm/LVqL3uwofB+eyP675wb9qBlWxbhLc9d47IMcxAy7NCCG9yfMnmqvfrF6jsD29gqL/4zpjSchv+lhq4wUVZx5uZJN/UqRhK9+GFn20l3lLPp7gSkLKNN+DanCehe2os6Mq0YsuKlE8JKOIlcaEvxEYyMsfTDYm1hwMtBXtUk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=sTWuKd/u; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="sTWuKd/u" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05FACC4CECD; Wed, 6 Nov 2024 12:41:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1730896892; bh=gfLlThbJNrGIMTjYZ7GB32DMkWjX3+uaegcCrCY/GWE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sTWuKd/u1F+M+MtftFqrWknvG+pv/t0/qHjJnrqA1r2A0xINBXVSZKVRFGo6Stf/+ vWEbVx7nnTumw8AOgMFAx0BuQIG8WHOEY+znBWsYEPuXUF9LoGPr6V+bMVkhyWps4E aCbXr9tTYOgHxVtSaYU8y2W6b5QCYxRlglYjYRYc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wander Lairson Costa , Yuying Ma , Przemek Kitszel , Rafal Romanowski , Jacob Keller , Simon Horman , Paolo Abeni , Sasha Levin Subject: [PATCH 5.10 070/110] igb: Disable threaded IRQ for igb_msix_other Date: Wed, 6 Nov 2024 13:04:36 +0100 Message-ID: <20241106120305.123658161@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241106120303.135636370@linuxfoundation.org> References: <20241106120303.135636370@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wander Lairson Costa [ Upstream commit 338c4d3902feb5be49bfda530a72c7ab860e2c9f ] During testing of SR-IOV, Red Hat QE encountered an issue where the ip link up command intermittently fails for the igbvf interfaces when using the PREEMPT_RT variant. Investigation revealed that e1000_write_posted_mbx returns an error due to the lack of an ACK from e1000_poll_for_ack. The underlying issue arises from the fact that IRQs are threaded by default under PREEMPT_RT. While the exact hardware details are not available, it appears that the IRQ handled by igb_msix_other must be processed before e1000_poll_for_ack times out. However, e1000_write_posted_mbx is called with preemption disabled, leading to a scenario where the IRQ is serviced only after the failure of e1000_write_posted_mbx. To resolve this, we set IRQF_NO_THREAD for the affected interrupt, ensuring that the kernel handles it immediately, thereby preventing the aforementioned error. Reproducer: #!/bin/bash # echo 2 > /sys/class/net/ens14f0/device/sriov_numvfs ipaddr_vlan=3 nic_test=ens14f0 vf=${nic_test}v0 while true; do ip link set ${nic_test} mtu 1500 ip link set ${vf} mtu 1500 ip link set $vf up ip link set ${nic_test} vf 0 vlan ${ipaddr_vlan} ip addr add 172.30.${ipaddr_vlan}.1/24 dev ${vf} ip addr add 2021:db8:${ipaddr_vlan}::1/64 dev ${vf} if ! ip link show $vf | grep 'state UP'; then echo 'Error found' break fi ip link set $vf down done Signed-off-by: Wander Lairson Costa Fixes: 9d5c824399de ("igb: PCI-Express 82575 Gigabit Ethernet driver") Reported-by: Yuying Ma Reviewed-by: Przemek Kitszel Tested-by: Rafal Romanowski Signed-off-by: Jacob Keller Reviewed-by: Simon Horman Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/igb/igb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index 17cdda3fe415a..e1936aa94077b 100644 --- a/drivers/net/ethernet/intel/igb/igb_main.c +++ b/drivers/net/ethernet/intel/igb/igb_main.c @@ -936,7 +936,7 @@ static int igb_request_msix(struct igb_adapter *adapter) int i, err = 0, vector = 0, free_vector = 0; err = request_irq(adapter->msix_entries[vector].vector, - igb_msix_other, 0, netdev->name, adapter); + igb_msix_other, IRQF_NO_THREAD, netdev->name, adapter); if (err) goto err_out; -- 2.43.0