From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E8D11DEFF5; Wed, 6 Nov 2024 12:07:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730894825; cv=none; b=eOQlZr8258UlGDfxhC9X9QoF3d9C1DUre0i8Yh4LvoX//7BsEycL1srA8q63jdGrNyF75w4yhMvWPOXslL2YZGjJCsaf9BMXuwGf+DDJlHpwx+MEIy2l3zPdoLery2vqeSVeTrhov/2XQY7DY4EfunBIUCDVbxvncWEfwSpmpt4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730894825; c=relaxed/simple; bh=/EeDLNZBSSKauR90LcAR96dHDp5goPASQ7C8vINy9xM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fhR3OG9IPU5LRDj5YQ6/NuOnToU5e2v5FBvkQSg3VqCy16PKlP0GhUcQnA6OnqTOTQbfheekB1icOsq8m+CEfJkrsHE1tc70mLv2Wln75Fe3G/eV92jaLGSPeYM+b+Z0aI+2/QW15TgiEo2fGzbGVaScIt6UWSMaSYu+AbjXyfM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=RWNww4Xg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="RWNww4Xg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A0F7C4CECD; Wed, 6 Nov 2024 12:07:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1730894824; bh=/EeDLNZBSSKauR90LcAR96dHDp5goPASQ7C8vINy9xM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RWNww4Xg1QoKtjSjJ5u9FTfFJRJzFb5527HmgIiHlNrhR4DFYQEQE0TyuXRXb0Ygu dDrrYFOZ2snQ4hF2MbhQeFgci6VRLI05MX4gR7OwW+2NUH5p9dkvLYXuxx/Wieqgih fa79/QeXmgWziQMWqQiBlnEKGov21/iX+38MscMM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Moon Yeounsu , Christophe JAILLET , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 005/350] net: ethernet: use ip_hdrlen() instead of bit shift Date: Wed, 6 Nov 2024 12:58:53 +0100 Message-ID: <20241106120321.003548602@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241106120320.865793091@linuxfoundation.org> References: <20241106120320.865793091@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Moon Yeounsu [ Upstream commit 9a039eeb71a42c8b13408a1976e300f3898e1be0 ] `ip_hdr(skb)->ihl << 2` is the same as `ip_hdrlen(skb)` Therefore, we should use a well-defined function not a bit shift to find the header length. It also compresses two lines to a single line. Signed-off-by: Moon Yeounsu Reviewed-by: Christophe JAILLET Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/jme.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c index a5ab6f3403ae..9b2471b2a955 100644 --- a/drivers/net/ethernet/jme.c +++ b/drivers/net/ethernet/jme.c @@ -966,15 +966,13 @@ jme_udpsum(struct sk_buff *skb) if (skb->protocol != htons(ETH_P_IP)) return csum; skb_set_network_header(skb, ETH_HLEN); - if ((ip_hdr(skb)->protocol != IPPROTO_UDP) || - (skb->len < (ETH_HLEN + - (ip_hdr(skb)->ihl << 2) + - sizeof(struct udphdr)))) { + + if (ip_hdr(skb)->protocol != IPPROTO_UDP || + skb->len < (ETH_HLEN + ip_hdrlen(skb) + sizeof(struct udphdr))) { skb_reset_network_header(skb); return csum; } - skb_set_transport_header(skb, - ETH_HLEN + (ip_hdr(skb)->ihl << 2)); + skb_set_transport_header(skb, ETH_HLEN + ip_hdrlen(skb)); csum = udp_hdr(skb)->check; skb_reset_transport_header(skb); skb_reset_network_header(skb); -- 2.43.0