From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D3921E7C1F; Wed, 6 Nov 2024 12:58:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730897910; cv=none; b=UOEIKQp/EVOeurCcyUJIMAdtyHe7RriCZNXcxxRCwK11JX1CWuPxk0J2g/mN1P4moVmPGmz+/0JjUuwF/33GQ0FGzpHQzyP2pLuwoCfSJFKan/ItUUncXUxyzA13056uDWJiFDXmjoen0Lwd0cXyTPabD/KQV1sbVgPfwd8P/Dw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730897910; c=relaxed/simple; bh=avvS9h9fmX4B3zuyAS0aziWtFc8QezOWrhp9M73KFf8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DuDq6SikHgZbfK5+H7W58cZCXzWfQziAbbCepDE5lPV1n9F3Lo80XHXEmvz051bgCJhn0X56uLuYx4rcbNr40LMC9dLaCu74Jp4MKOlk9t4S7GBKva3ZUqMj8CwyRWEWRCkkGDsHS684Y+wlMpFxrNSD6NdsockCDWaUOrVR0B0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=EBV6PwKd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="EBV6PwKd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9822FC4CECD; Wed, 6 Nov 2024 12:58:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1730897910; bh=avvS9h9fmX4B3zuyAS0aziWtFc8QezOWrhp9M73KFf8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EBV6PwKdbxMdMgn1vEXYlRA1UoSg1V6nsstaf/ElQ4zhSFG4ZFTr3IIDg8LjopcW+ +NbKawihOGpD2AmDq3JRb8X2zk8rWKBjD1c+vLn/idJK4pHRjnURLY5diRvSs3Cq6S KrHUXJwQzmNW3KOvW/eUbuJKQEk3uh8y+eExj9d4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Krzysztof Kozlowski , Damien Le Moal , Philipp Zabel , Sasha Levin Subject: [PATCH 5.4 059/462] reset: berlin: fix OF node leak in probe() error path Date: Wed, 6 Nov 2024 12:59:12 +0100 Message-ID: <20241106120332.973060378@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241106120331.497003148@linuxfoundation.org> References: <20241106120331.497003148@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Krzysztof Kozlowski [ Upstream commit 5f58a88cc91075be38cec69b7cb70aaa4ba69e8b ] Driver is leaking OF node reference on memory allocation failure. Acquire the OF node reference after memory allocation to fix this and keep it simple. Fixes: aed6f3cadc86 ("reset: berlin: convert to a platform driver") Signed-off-by: Krzysztof Kozlowski Reviewed-by: Damien Le Moal Link: https://lore.kernel.org/r/20240825-reset-cleanup-scoped-v1-1-03f6d834f8c0@linaro.org Signed-off-by: Philipp Zabel Signed-off-by: Sasha Levin --- drivers/reset/reset-berlin.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/reset/reset-berlin.c b/drivers/reset/reset-berlin.c index 371197bbd0556..542d32719b8ae 100644 --- a/drivers/reset/reset-berlin.c +++ b/drivers/reset/reset-berlin.c @@ -68,13 +68,14 @@ static int berlin_reset_xlate(struct reset_controller_dev *rcdev, static int berlin2_reset_probe(struct platform_device *pdev) { - struct device_node *parent_np = of_get_parent(pdev->dev.of_node); + struct device_node *parent_np; struct berlin_reset_priv *priv; priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); if (!priv) return -ENOMEM; + parent_np = of_get_parent(pdev->dev.of_node); priv->regmap = syscon_node_to_regmap(parent_np); of_node_put(parent_np); if (IS_ERR(priv->regmap)) -- 2.43.0