From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E58D1F1318; Wed, 6 Nov 2024 13:03:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730898189; cv=none; b=hRc1q2r1IUrBJnFF9jDww9/pYIodXEW1SLBzz1hVpjEx8wSNOjBpjZMqAesGJ77tePWZtP/znm1dlsyToSwy61LYQrxktazOVN5xFvSwcBbZW0nahnCh2LAKzaynTpbCbSpl5755J228EYEdy/03n3km4+Gpokp3qX0tFAWVp0s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730898189; c=relaxed/simple; bh=RK1c7DeV+6kc8990AaM7oHqvWKvJGk5Ze2P7aKATyf8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YU5NprWnUnLYEBOAsoID8hfn1G8WU5l2ZJXcgBPW88KssqdO3yuy1Z48RGg7wnbfRzhZ6IycitsJlRCkP1mQBK/f+ynoh8cBXXHH0V93WJ/FTbw7cTkxSr3r3b/oc1PzTrY7Rzpa8sTaDiFq8wfnfpQL+dz5DoO6/k0sijLbu7A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=IY0VEpCV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="IY0VEpCV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 347D4C4CED6; Wed, 6 Nov 2024 13:03:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1730898189; bh=RK1c7DeV+6kc8990AaM7oHqvWKvJGk5Ze2P7aKATyf8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IY0VEpCVk2X7SxdffgTA2So/gNyLkt3ZSMEsmvIhQKru3nkwkNPZFqDG8SLTd/o10 R6DbvPRuXuomqgO1o4XqZ1NLqCQxil3n39GnAS2QayrQsx/M3vLJfWlCWVevzBjqGi NRUofva/XtjlFDkAOnLk8IaSevVFtXdX21XjHCKY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ian Rogers , Adrian Hunter , Alexander Shishkin , Athira Rajeev , Chaitanya S Prakash , Colin Ian King , David Ahern , Dominique Martinet , Ingo Molnar , James Clark , Jiri Olsa , John Garry , Junhao He , Kan Liang , Mark Rutland , Masami Hiramatsu , Namhyung Kim , Peter Zijlstra , Yang Jihong , Arnaldo Carvalho de Melo , Sasha Levin Subject: [PATCH 5.4 107/462] perf time-utils: Fix 32-bit nsec parsing Date: Wed, 6 Nov 2024 13:00:00 +0100 Message-ID: <20241106120334.151015794@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241106120331.497003148@linuxfoundation.org> References: <20241106120331.497003148@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ian Rogers [ Upstream commit 38e2648a81204c9fc5b4c87a8ffce93a6ed91b65 ] The "time utils" test fails in 32-bit builds: ... parse_nsec_time("18446744073.709551615") Failed. ptime 4294967295709551615 expected 18446744073709551615 ... Switch strtoul to strtoull as an unsigned long in 32-bit build isn't 64-bits. Fixes: c284d669a20d408b ("perf tools: Move parse_nsec_time to time-utils.c") Signed-off-by: Ian Rogers Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Athira Rajeev Cc: Chaitanya S Prakash Cc: Colin Ian King Cc: David Ahern Cc: Dominique Martinet Cc: Ingo Molnar Cc: James Clark Cc: Jiri Olsa Cc: John Garry Cc: Junhao He Cc: Kan Liang Cc: Mark Rutland Cc: Masami Hiramatsu Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Yang Jihong Link: https://lore.kernel.org/r/20240831070415.506194-3-irogers@google.com Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/util/time-utils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/time-utils.c b/tools/perf/util/time-utils.c index 3024439216816..1b91ccd4d5234 100644 --- a/tools/perf/util/time-utils.c +++ b/tools/perf/util/time-utils.c @@ -20,7 +20,7 @@ int parse_nsec_time(const char *str, u64 *ptime) u64 time_sec, time_nsec; char *end; - time_sec = strtoul(str, &end, 10); + time_sec = strtoull(str, &end, 10); if (*end != '.' && *end != '\0') return -1; @@ -38,7 +38,7 @@ int parse_nsec_time(const char *str, u64 *ptime) for (i = strlen(nsec_buf); i < 9; i++) nsec_buf[i] = '0'; - time_nsec = strtoul(nsec_buf, &end, 10); + time_nsec = strtoull(nsec_buf, &end, 10); if (*end != '\0') return -1; } else -- 2.43.0