From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB5E31F4FCE; Wed, 6 Nov 2024 13:05:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730898343; cv=none; b=kRnhVJL1C6kk7+mtqabWOR8f/aBp+I2Sv1Uu2zApsQ9JuwlGapmhI37xJt7yPyvpABU9xudPhIOLXf01G6hxRw2bjwvCcWxAMtxqRY+mtQx4g5AO6B+VaXUkGztSwaa0L7JU20yzPsY+MDgAoC5NOYrQWmbImZrAhuKRDc8MLgE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730898343; c=relaxed/simple; bh=zUVhxGhuNWTRBNluesvZi4v9UBBktpsqenrefDCAkLE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ck9gHHlkNQojzTvK4PmomeJhgc5EXeF6NWkb0fi02M9nv0GIg3M2Fy3AnCHccxsjoqOVHttUWsQGbV+V45DgibUFdHM4t9r6bbQL9nvodzGGLy/zdr9w8Iz/E35hfTNCRzmSq6VRwWr/NYQtHY+qnbSW/rZz0+F/FIUYpa1tt5s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=t13WJVOc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="t13WJVOc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA72EC4CECD; Wed, 6 Nov 2024 13:05:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1730898343; bh=zUVhxGhuNWTRBNluesvZi4v9UBBktpsqenrefDCAkLE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=t13WJVOcDPE8ypM/3nc+x7Ee4YDY0ItZHLVEhm8CKSMtfml3m6jg2HubN+F4sdiem 91ycC31Vq7TBBaZ0TU9n0RRyIWqgb/zA59lm/8HKWBzatLXM2zIWj6QIkBLHQeKkRo KhJ9FYiWwaPAlp9nO2Ee6eL13ffDsKN1jQjIDN2o= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+f4e0f821e3a3b7cee51d@syzkaller.appspotmail.com, Xin Long , Marcelo Ricardo Leitner , Paolo Abeni , Sasha Levin Subject: [PATCH 5.4 189/462] sctp: set sk_state back to CLOSED if autobind fails in sctp_listen_start Date: Wed, 6 Nov 2024 13:01:22 +0100 Message-ID: <20241106120336.183076985@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241106120331.497003148@linuxfoundation.org> References: <20241106120331.497003148@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Xin Long [ Upstream commit 8beee4d8dee76b67c75dc91fd8185d91e845c160 ] In sctp_listen_start() invoked by sctp_inet_listen(), it should set the sk_state back to CLOSED if sctp_autobind() fails due to whatever reason. Otherwise, next time when calling sctp_inet_listen(), if sctp_sk(sk)->reuse is already set via setsockopt(SCTP_REUSE_PORT), sctp_sk(sk)->bind_hash will be dereferenced as sk_state is LISTENING, which causes a crash as bind_hash is NULL. KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007] RIP: 0010:sctp_inet_listen+0x7f0/0xa20 net/sctp/socket.c:8617 Call Trace: __sys_listen_socket net/socket.c:1883 [inline] __sys_listen+0x1b7/0x230 net/socket.c:1894 __do_sys_listen net/socket.c:1902 [inline] Fixes: 5e8f3f703ae4 ("sctp: simplify sctp listening code") Reported-by: syzbot+f4e0f821e3a3b7cee51d@syzkaller.appspotmail.com Signed-off-by: Xin Long Acked-by: Marcelo Ricardo Leitner Link: https://patch.msgid.link/a93e655b3c153dc8945d7a812e6d8ab0d52b7aa0.1727729391.git.lucien.xin@gmail.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- net/sctp/socket.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/sctp/socket.c b/net/sctp/socket.c index 614130ff6ba06..eef807edd61da 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -8396,8 +8396,10 @@ static int sctp_listen_start(struct sock *sk, int backlog) */ inet_sk_set_state(sk, SCTP_SS_LISTENING); if (!ep->base.bind_addr.port) { - if (sctp_autobind(sk)) + if (sctp_autobind(sk)) { + inet_sk_set_state(sk, SCTP_SS_CLOSED); return -EAGAIN; + } } else { if (sctp_get_port(sk, inet_sk(sk)->inet_num)) { inet_sk_set_state(sk, SCTP_SS_CLOSED); -- 2.43.0