From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD7791E1336; Wed, 6 Nov 2024 13:05:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730898322; cv=none; b=jP138VG54yq+e52iBO0tW9/CYo7s1rty4IZeoz5hSkPQ2D+b9s7DysEUhmclTs+y1YSRsjuy/DqWGIWTdBoCq+DR745aPdPLxNo1Agl2tQ4EPbabqlZ1f9oLsiKhuzopTTT4URlVxKcDKuH+VJADZ8xrdsr5AM1gmo/AwsYokyk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730898322; c=relaxed/simple; bh=PEVe6yDz+aMCMMari1bXPnZkVv6eDlJ1T+BVoERP3d8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BunORIt8c8dMeukY3Jk/kYBvCsoO5dYSoLfPm12Re2QhhChKR8+ilnMS6adFWMUDq3Weybfrfc2KNAQHDi9+njMO8hhwK1HdzLWkCeMbzJiiH8Cs4BhAsMAncpeRi7IVC0ARCtOx5s7cWNIiYSsi52ISO2f9WDVVsr9qvuIsTPM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=UexOqnV9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="UexOqnV9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 111A0C4CECD; Wed, 6 Nov 2024 13:05:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1730898322; bh=PEVe6yDz+aMCMMari1bXPnZkVv6eDlJ1T+BVoERP3d8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UexOqnV9xgQ77zAXkKkjpbqqvvTlOrY7HmdNcXqafSfsLyu/JiHg6CHaRu7oGNJip /4OO9L9PVNA7UdQWslvSF1BQR3wFmbVoq3+kigXTtCA6dAowLPN82CAR/n8swCNVGa DbzLlAW7OXETg7cI5WGTrfLJcRbZegjr/tO1fFN4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Armin Wolf , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 5.4 200/462] ACPICA: Fix memory leak if acpi_ps_get_next_namepath() fails Date: Wed, 6 Nov 2024 13:01:33 +0100 Message-ID: <20241106120336.455584133@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241106120331.497003148@linuxfoundation.org> References: <20241106120331.497003148@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Armin Wolf [ Upstream commit 5accb265f7a1b23e52b0ec42313d1e12895552f4 ] ACPICA commit 2802af722bbde7bf1a7ac68df68e179e2555d361 If acpi_ps_get_next_namepath() fails, the previously allocated union acpi_parse_object needs to be freed before returning the status code. The issue was first being reported on the Linux ACPI mailing list: Link: https://lore.kernel.org/linux-acpi/56f94776-484f-48c0-8855-dba8e6a7793b@yandex.ru/T/ Link: https://github.com/acpica/acpica/commit/2802af72 Signed-off-by: Armin Wolf Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/acpi/acpica/psargs.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/acpi/acpica/psargs.c b/drivers/acpi/acpica/psargs.c index e62c7897fdf18..78afbfc762d36 100644 --- a/drivers/acpi/acpica/psargs.c +++ b/drivers/acpi/acpica/psargs.c @@ -820,6 +820,10 @@ acpi_ps_get_next_arg(struct acpi_walk_state *walk_state, acpi_ps_get_next_namepath(walk_state, parser_state, arg, ACPI_NOT_METHOD_CALL); + if (ACPI_FAILURE(status)) { + acpi_ps_free_op(arg); + return_ACPI_STATUS(status); + } } else { /* Single complex argument, nothing returned */ @@ -854,6 +858,10 @@ acpi_ps_get_next_arg(struct acpi_walk_state *walk_state, acpi_ps_get_next_namepath(walk_state, parser_state, arg, ACPI_POSSIBLE_METHOD_CALL); + if (ACPI_FAILURE(status)) { + acpi_ps_free_op(arg); + return_ACPI_STATUS(status); + } if (arg->common.aml_opcode == AML_INT_METHODCALL_OP) { -- 2.43.0