From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2EBF1E22E2; Wed, 6 Nov 2024 13:06:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730898384; cv=none; b=lnNDtpy7rEDXIaf3IFb11IV/5y+lNFNRV1ehUMFMigdk0UNxDMMrqVFK1kWxOz6C+Y6cmIvyO9m9IFnBD1V5IP3XGSEnmeBsH2S42nC+Ngl//2M8lS7Bb31kqAiNPI4rCwOqOugdj/14Uj9YZ479ENgy9B2WpDWNOw6xZMtQo2Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730898384; c=relaxed/simple; bh=UZexzmuSoBYx4M4DGd8VBxw7nwIZ4TcgfTsf67C6XCM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cRhMItmKF7HIsZfrW00etBEnRRINdnoudGogU/biNPEQ6Xz2PBfRqPfqWp2yfOYoBSk2mYiXw3jr+z1JcwDtM6TNvwSTgjJN6piMhpZzjHQpCJA2EvpGiAzOch4vYpIb2BQpOQdi7J/lfog+XThhpuLPq/xU3+I4hO+jJ/lQm6Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=dYthNI7r; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="dYthNI7r" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C50DC4CECD; Wed, 6 Nov 2024 13:06:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1730898384; bh=UZexzmuSoBYx4M4DGd8VBxw7nwIZ4TcgfTsf67C6XCM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dYthNI7rEiK0k3CijuauI53di/qEAPd0oU0tBt/ImuUIznlvPGHysObNLZQCsEH68 a2kqzsL8nyw1qv9lVEHM7YWA6UQjsenpNTgC+BfoueKIRjG4AKSKbIWqIehncieaSy ZAbmJ1fD2gprbEA3OFugzhIZJMmfanpDuSYFuS3c= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Kaixin Wang , Helge Deller , Sasha Levin Subject: [PATCH 5.4 219/462] fbdev: pxafb: Fix possible use after free in pxafb_task() Date: Wed, 6 Nov 2024 13:01:52 +0100 Message-ID: <20241106120336.931828717@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241106120331.497003148@linuxfoundation.org> References: <20241106120331.497003148@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kaixin Wang [ Upstream commit 4a6921095eb04a900e0000da83d9475eb958e61e ] In the pxafb_probe function, it calls the pxafb_init_fbinfo function, after which &fbi->task is associated with pxafb_task. Moreover, within this pxafb_init_fbinfo function, the pxafb_blank function within the &pxafb_ops struct is capable of scheduling work. If we remove the module which will call pxafb_remove to make cleanup, it will call unregister_framebuffer function which can call do_unregister_framebuffer to free fbi->fb through put_fb_info(fb_info), while the work mentioned above will be used. The sequence of operations that may lead to a UAF bug is as follows: CPU0 CPU1 | pxafb_task pxafb_remove | unregister_framebuffer(info) | do_unregister_framebuffer(fb_info) | put_fb_info(fb_info) | // free fbi->fb | set_ctrlr_state(fbi, state) | __pxafb_lcd_power(fbi, 0) | fbi->lcd_power(on, &fbi->fb.var) | //use fbi->fb Fix it by ensuring that the work is canceled before proceeding with the cleanup in pxafb_remove. Note that only root user can remove the driver at runtime. Signed-off-by: Kaixin Wang Signed-off-by: Helge Deller Signed-off-by: Sasha Levin --- drivers/video/fbdev/pxafb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c index 27635926cea3f..e8d51dc4bc283 100644 --- a/drivers/video/fbdev/pxafb.c +++ b/drivers/video/fbdev/pxafb.c @@ -2416,6 +2416,7 @@ static int pxafb_remove(struct platform_device *dev) info = &fbi->fb; pxafb_overlay_exit(fbi); + cancel_work_sync(&fbi->task); unregister_framebuffer(info); pxafb_disable_controller(fbi); -- 2.43.0