From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC9B01E1A25; Wed, 6 Nov 2024 13:06:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730898402; cv=none; b=sgFrOgQjhsx5XkXFo/fzAbgI98kmrq1CXlgba8dK9UJIYR1o54drjim+wyuEHe6UfENdVkoOQnOEbv9SffHMO0CrFt/5tvLNtSmpCTySRNLdycch0LuaU+Jmmxg58M0KhuxNucI2+E3nHMEjnw9JP6B9Ao7mT4Mvp0KwD5zMtK0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730898402; c=relaxed/simple; bh=b2vVDA7m37YMNeTWlv/bYw2QmT5XM2Ed2RE70Lr3YSI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LVNCUNexvols34UrnIOz8Ccgy8+P9R2HOpf3YmsNzS1L1K1PVny7IeYyYUfnvZ21N+syOCs5leLmJq4g6gItHBgPt7+kkzlq3muPl5D2MxbDzRaZqeNasDIGTIQshxKDnmGJc44E1OLsn7yuGHvS5C4km5U4yisZBnSzulf13pg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=WTrTHTi3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="WTrTHTi3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12E20C4CECD; Wed, 6 Nov 2024 13:06:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1730898402; bh=b2vVDA7m37YMNeTWlv/bYw2QmT5XM2Ed2RE70Lr3YSI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WTrTHTi3b2HPKfx5XfQA1xl2wCPEmmX+001+ZQa1RYQYN+mivavwJZAeRnDpcCHTp mbECf1W3PaPov/x35naahIxlMhgOBHMzXfhkvnJTxDvig2PcDkFhcc2v+smtMnTtI1 bMpzJ278R2eB/ug9H1CB0EtfjamBOd7/L928zqVc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+02341e0daa42a15ce130@syzkaller.appspotmail.com, Zhao Mengmeng , Dave Kleikamp , Sasha Levin Subject: [PATCH 5.4 225/462] jfs: Fix uninit-value access of new_ea in ea_buffer Date: Wed, 6 Nov 2024 13:01:58 +0100 Message-ID: <20241106120337.078524611@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241106120331.497003148@linuxfoundation.org> References: <20241106120331.497003148@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zhao Mengmeng [ Upstream commit 2b59ffad47db1c46af25ccad157bb3b25147c35c ] syzbot reports that lzo1x_1_do_compress is using uninit-value: ===================================================== BUG: KMSAN: uninit-value in lzo1x_1_do_compress+0x19f9/0x2510 lib/lzo/lzo1x_compress.c:178 ... Uninit was stored to memory at: ea_put fs/jfs/xattr.c:639 [inline] ... Local variable ea_buf created at: __jfs_setxattr+0x5d/0x1ae0 fs/jfs/xattr.c:662 __jfs_xattr_set+0xe6/0x1f0 fs/jfs/xattr.c:934 ===================================================== The reason is ea_buf->new_ea is not initialized properly. Fix this by using memset to empty its content at the beginning in ea_get(). Reported-by: syzbot+02341e0daa42a15ce130@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=02341e0daa42a15ce130 Signed-off-by: Zhao Mengmeng Signed-off-by: Dave Kleikamp Signed-off-by: Sasha Levin --- fs/jfs/xattr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/jfs/xattr.c b/fs/jfs/xattr.c index aea5531559c06..4ebee6e4dc1f9 100644 --- a/fs/jfs/xattr.c +++ b/fs/jfs/xattr.c @@ -434,6 +434,8 @@ static int ea_get(struct inode *inode, struct ea_buffer *ea_buf, int min_size) int rc; int quota_allocation = 0; + memset(&ea_buf->new_ea, 0, sizeof(ea_buf->new_ea)); + /* When fsck.jfs clears a bad ea, it doesn't clear the size */ if (ji->ea.flag == 0) ea_size = 0; -- 2.43.0